[FIX] hr_employee_second_lastname: fix access error when reading employees public info#1562
Conversation
|
Hi @luisg123v, |
OCA-git-bot
added
series:19.0
mod:hr_employee_second_lastname
isaako34
force-pushed
the
19.0-hr_employee_second_lastname-fix-access-error-isaako34
branch
from
ca96749 to
aad9dd7
Compare
luisg123v
left a comment
luisg123v
left a comment
There was a problem hiding this comment.
Regarding commit message:
- Title could focuse on the actual issue, which is an access error when reading employees public info
- The reference
[1](ceb9584) is for the migration ofhr_employee_firstname, nothr_employee_second_lastname.
isaako34
force-pushed
the
19.0-hr_employee_second_lastname-fix-access-error-isaako34
branch
from
aad9dd7 to
84844b4
Compare
isaako34
changed the title
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@luisg123v your merge command was aborted due to failed check(s), which you can inspect on this commit of 19.0-ocabot-merge-pr-1562-by-luisg123v-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
…oyees public info In v19, hr.employee.base was removed [1] and lastname2 was moved back to `hr.employee` but did not replicate it on `hr.employee.public`. Since lastname2 is part of the employee display name and not sensitive data, declare it as a related field on hr.employee.public so non-HR users can read employees without triggering an AccessError. [1]: OCA@d2e5fe75
isaako34
force-pushed
the
19.0-hr_employee_second_lastname-fix-access-error-isaako34
branch
from
84844b4 to
cffd026
Compare
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at ec633ea. Thanks a lot for contributing to OCA. ❤️ |
4 participants
In v19, hr.employee.base was removed 1 and lastname2 was moved back to
hr.employeebut did not replicate it onhr.employee.public.Since lastname2 is part of the employee display name and not sensitive data, declare it as a related field on hr.employee.public so non-HR users can read employees without triggering an AccessError.