Skip to content

Comments

[13.0][MIG] hr_employee_relative#775

Merged
OCA-git-bot merged 5 commits intoOCA:13.0from
ecosoft-odoo:13.0-mig-hr_employee_relative
May 8, 2020
Merged

[13.0][MIG] hr_employee_relative#775
OCA-git-bot merged 5 commits intoOCA:13.0from
ecosoft-odoo:13.0-mig-hr_employee_relative

Conversation

@Saran440
Copy link
Member

@Saran440 Saran440 commented Jan 21, 2020

test script depend on #806

@Saran440 Saran440 force-pushed the 13.0-mig-hr_employee_relative branch 2 times, most recently from 44a6caf to b9522e6 Compare January 21, 2020 09:37
@Saran440 Saran440 added this to the 13.0 milestone Feb 12, 2020
@Saran440 Saran440 force-pushed the 13.0-mig-hr_employee_relative branch from b9522e6 to 356ed31 Compare March 2, 2020 11:11
@Saran440 Saran440 force-pushed the 13.0-mig-hr_employee_relative branch from 3ce0925 to 1423801 Compare March 3, 2020 10:16
@Saran440 Saran440 force-pushed the 13.0-mig-hr_employee_relative branch 3 times, most recently from 85a13bd to 8a98a5c Compare March 25, 2020 11:30
@alexey-pelykh
Copy link
Contributor

@Saran440 how this depends on #806 ?

@Saran440
Copy link
Member Author

@alexey-pelykh it's not depend but codecov compare test script with hr_employee_firstname. I don't know why.

@Saran440 Saran440 force-pushed the 13.0-mig-hr_employee_relative branch 2 times, most recently from fdcb2fe to 0aea8ad Compare March 30, 2020 09:00
@alexey-pelykh
Copy link
Contributor

I think that commit history can be cleanup by merging as "fixup" the translation and bot commits to previous significant one, e.g.:
image
can be made a single commit and these:
image

Yet otherwise I guess we can merge

Copy link

@jarroyomorales jarroyomorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runbot, LGTM 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@alexey-pelykh
Copy link
Contributor

@Saran440 please squash commits as per https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0 and let's merge:

Squash administrative commits (if any) with the previous commit for reducing commit noise. They are named as "[UPD] README.rst", "[UPD] Update $MODULE.pot", "Update translation files" and similar names, and comes from OCA-git-bot, oca-travis or oca-transbot.

@Saran440 Saran440 force-pushed the 13.0-mig-hr_employee_relative branch from 0aea8ad to cace6a0 Compare May 8, 2020 10:27
@Saran440 Saran440 force-pushed the 13.0-mig-hr_employee_relative branch from cace6a0 to e0e6a7b Compare May 8, 2020 10:29
@Saran440
Copy link
Member Author

Saran440 commented May 8, 2020

@alexey-pelykh Sorry for late. Fixed. Thank you for reference :)

@alexey-pelykh
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-775-by-alexey-pelykh-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b03fb33 into OCA:13.0 May 8, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7098274. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants