Skip to content

Conversation

@StephanRozendaal
Copy link
Contributor

Change includes:

  • Add try-except statements on analyze actions that could potentially crash the analyze process.

Add try-except statements on analyze actions that could
potentially crash the analyze process.
Changes include:
 - fix error values
 - use error instead of warning
Fix a programming mistake in the analyze call.
By @RoelAdriaans
@RoelAdriaans
Copy link

Review request @oscarolar @bizzappdev
cc @elicoidal

Copy link
Contributor

@bizzappdev bizzappdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@oscarolar oscarolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bizzappdev
Copy link
Contributor

@elicoidal Can you please take care for merging?

Copy link

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Version number

Bump the version number of github_connector to '11.0.1.1.1'.
@elicoidal elicoidal added this to the 11.0 milestone Oct 2, 2018
Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
@elicoidal elicoidal merged commit 90275e7 into OCA:11.0 Oct 2, 2018
cristinamartinrod pushed a commit to Tecnativa/interface-github that referenced this pull request Jan 11, 2019
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
cristinamartinrod pushed a commit to Tecnativa/interface-github that referenced this pull request Jan 12, 2019
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
cristinamartinrod pushed a commit to Tecnativa/interface-github that referenced this pull request Jan 12, 2019
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
cubells pushed a commit to Tecnativa/interface-github that referenced this pull request Apr 5, 2019
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
Tardo pushed a commit to Tecnativa/interface-github that referenced this pull request Jan 29, 2020
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
Tardo pushed a commit to Tecnativa/interface-github that referenced this pull request Mar 3, 2020
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
ernestotejeda pushed a commit to Tecnativa/interface-github that referenced this pull request Mar 16, 2020
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
ernestotejeda pushed a commit to Tecnativa/interface-github that referenced this pull request Mar 16, 2020
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
Tardo pushed a commit to Tecnativa/interface-github that referenced this pull request Apr 14, 2020
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
Tardo pushed a commit to Tecnativa/interface-github that referenced this pull request Jun 17, 2020
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
pedrobaeza pushed a commit to Tecnativa/interface-github that referenced this pull request Jun 18, 2020
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
joao-p-marques pushed a commit to Tecnativa/interface-github that referenced this pull request Jun 22, 2021
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
OpenCode pushed a commit to OpenCode/interface-github that referenced this pull request Jul 15, 2021
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
ernestotejeda pushed a commit to Tecnativa/interface-github that referenced this pull request Jul 30, 2021
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
OpenCode pushed a commit to OpenCode/interface-github that referenced this pull request Jun 22, 2022
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
OpenCode pushed a commit to OpenCode/interface-github that referenced this pull request Jun 23, 2022
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
victoralmau pushed a commit to Tecnativa/interface-github that referenced this pull request Oct 11, 2022
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
victoralmau pushed a commit to Tecnativa/interface-github that referenced this pull request Nov 15, 2022
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
victoralmau pushed a commit to Tecnativa/interface-github that referenced this pull request Nov 15, 2022
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
victoralmau pushed a commit to Tecnativa/interface-github that referenced this pull request Nov 17, 2022
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
carolinafernandez-tecnativa pushed a commit to Tecnativa/interface-github that referenced this pull request Jan 8, 2024
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
carolinafernandez-tecnativa pushed a commit to Tecnativa/interface-github that referenced this pull request Jan 9, 2024
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
carolinafernandez-tecnativa pushed a commit to Tecnativa/interface-github that referenced this pull request Mar 7, 2024
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
victoralmau pushed a commit to Tecnativa/interface-github that referenced this pull request Nov 8, 2024
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
victoralmau pushed a commit to Tecnativa/interface-github that referenced this pull request Nov 8, 2024
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
victoralmau pushed a commit to Tecnativa/interface-github that referenced this pull request Nov 11, 2024
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
carlos-lopez-tecnativa pushed a commit to Tecnativa/interface-github that referenced this pull request May 20, 2025
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
carlos-lopez-tecnativa pushed a commit to Tecnativa/interface-github that referenced this pull request May 20, 2025
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
carlos-lopez-tecnativa pushed a commit to Tecnativa/interface-github that referenced this pull request May 21, 2025
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
juppe pushed a commit to ahkio/interface-github that referenced this pull request Dec 15, 2025
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
juppe pushed a commit to ahkio/interface-github that referenced this pull request Dec 15, 2025
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
juppe pushed a commit to ahkio/interface-github that referenced this pull request Dec 15, 2025
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
juppe pushed a commit to ahkio/interface-github that referenced this pull request Dec 15, 2025
* [IMP] Add try-except on branch analyze action

Add try-except statements on analyze actions that could
potentially crash the analyze process.

* [REF] Fix error logging

Changes include:
 - fix error values
 - use error instead of warning

* [IMP] Fix error in analyze call

Fix a programming mistake in the analyze call.
By @RoelAdriaans

* [IMP] Bump version number of github_connector

Bump the version number of github_connector to '11.0.1.1.1'.

* [IMP] Bump version number of github_connector

Bump the version number of github_connector_odoo to
'11.0.1.1.1'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants