Skip to content

Conversation

@BhaveshHeliconia
Copy link
Contributor

No description provided.

pedrobaeza and others added 30 commits May 8, 2025 10:11
[MIG] document_url

* bump version to 9.0.1.0.0 and make it installable
* Update JS structure
* Add css in order to be compliant with odoo style
* Add a README.rst and OCA conventions
* Improve selector
* add fr.po for fr translation
* open link with target='_blank'
Without this patch, when you hover on the menu item, its background color does not change, and its cursor is a text one.

With this patch, the menu item styling matches those available in all surrounding menus.
Replace char © by word Copyright
Change format in usage description
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: knowledge-12.0/knowledge-12.0-document_url
Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-document_url/
Currently translated at 100.0% (14 of 14 strings)

Translation: knowledge-12.0/knowledge-12.0-document_url
Translate-URL: https://translation.odoo-community.org/projects/knowledge-12-0/knowledge-12-0-document_url/hr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: knowledge-13.0/knowledge-13.0-document_url
Translate-URL: https://translation.odoo-community.org/projects/knowledge-13-0/knowledge-13-0-document_url/
[MIG] document_url: Migration to 14.0
Define the add attachment and add URL buttons on the same line.
Allow downloading of url type attachments by clicking on the icon or the name.
Define the name of the url type attachments as links (allows to open it in a new tab).
Hide the download button for url attachments.
Force to set mimetype to "application/link" for url attachments.
Displays a link icon for url attachments.
TT30263
OCA-git-bot and others added 7 commits May 8, 2025 10:11
Currently translated at 100.0% (17 of 17 strings)

Translation: knowledge-17.0/knowledge-17.0-document_url
Translate-URL: https://translation.odoo-community.org/projects/knowledge-17-0/knowledge-17-0-document_url/sv/
Currently translated at 100.0% (17 of 17 strings)

Translation: knowledge-17.0/knowledge-17.0-document_url
Translate-URL: https://translation.odoo-community.org/projects/knowledge-17-0/knowledge-17-0-document_url/ca/
Fix download atachment widget.

Document_url when activated causes error when opening attachment link on the chatter window
This commit (odoo/odoo@366676c) move download buttons into a sub-component.
I modified the module behavior to use canDownload() method instead of adding a t-if in the view and prevent the chatter component from breaking when the message has attachments.
@BhaveshHeliconia BhaveshHeliconia mentioned this pull request May 8, 2025
11 tasks
@pedrobaeza
Copy link
Member

/ocabot migration document_url

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone May 8, 2025
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On runboat, I see 2 icons for the exact same purpose:

imagen

- Ernesto Tejeda
- Manuel Calero
- Víctor Martínez
- Matias Peralta - Adhoc SA
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should be deindented, as it doesn't belong to Tecnativa.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still pending.

<field name='target'>new</field>
<field name='view_mode'>form</field>
</record>
<data>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove data tag and deindent the rest (you can do it on the "pre-commit auto-fixes" one for reducing the noise).

@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-document_url branch from b1df567 to 15ec24a Compare May 27, 2025 06:29
@BhaveshHeliconia
Copy link
Contributor Author

@pedrobaeza Please Review.it's done.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better now, thanks, but still one comment pending and another thing I have discovered:

imagen

Please do it that removing the link, the name is put on the confirmation dialog.

TT56040

- Ernesto Tejeda
- Manuel Calero
- Víctor Martínez
- Matias Peralta - Adhoc SA
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still pending.

@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-document_url branch from 15ec24a to e497ab1 Compare May 28, 2025 09:29
@BhaveshHeliconia
Copy link
Contributor Author

@pedrobaeza, Please Review.it's fixed.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pedrobaeza pedrobaeza requested a review from victoralmau May 28, 2025 10:21
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review OK.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-542-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9bb3ef5 into OCA:18.0 May 28, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 56a0156. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.