[ADD] maintenance_plan module #2

grindtildeath · 2017-06-09T07:38:44Z

================
Maintenance Plan

This module extends the functionality of Odoo Maintenance module by allowing
an equipment to have different preventive maintenance kinds.

Installation

Install the module.

Usage

Instead of defining a period and duration for only one preventive maintenance
per equipment, you can define multiple preventive maintenance kind for each
equipment.

Maintenance Kinds have to be defined through the configuration menu. Their name
have to be unique and can be set as active or inactive, should these not be
used anymore.

On any equipment over the maintenance tab, the maintenance plan will appear
as an embedded list view, allowing to add different maintenance kind with their
own period and duration. The next maintenance date will then be computed
automatically according to today's date and the period defined, but the
maintenance request won't be created automatically as is the case in Odoo's
Maintenance module.

Instead, this module uses the original Cron job of Odoo's Maintenance module
to generate maintenance requests, should there not be any requests which is not
done, at the request date matching the maintenance plan next_maintenance_date
for this equipment and this maintenance kind !

dreispt · 2017-06-09T07:59:47Z

LGTM; please fix TravisCI

Suggestions/questions

It would be nice to have an action/button on "Equipment" to "Generate Next Maintenance"; the corresponding method would reused by the cron job.
Wouldn't month duration be better for the maintenance intervals? Either way, it could be a nice addition to also have a duration UoM selector - "Days" or "Months".

grindtildeath · 2017-06-09T09:28:11Z

@dreispt
Thanks for your suggestions.

We didn't code the 'Generate next maintenance' button as it would be used only at the creation of a new plan and the idea was to create all the maintenance plans and then run the ir.cron manually, should the requests be generated before it runs automatically.
A duration UoM could also be useful, but we wanted to keep it as simple as possible to begin with.

IMO both could be nice addition to the module, but I don't have time to spend on these features at the moment.

dreispt · 2017-06-09T09:54:00Z

@grindtildeath That's why I mentioned them as suggestion ideas.

dreispt · 2017-06-09T11:04:49Z

Does this have any conflict with the standard module's planned maintenance generation, if both are configured?
Does it disable it or will both will work?

Or from a user PoV:
have planned maintenance configured on my Equipments, and I then install this.
What is the impact and what do I need to take care to get everything right?

grindtildeath · 2017-06-16T10:11:13Z

@dreispt
I added a post-init hook, with the description in README.rst of what will happen and what should be done before installing should the standard feature already bu used.
Feel free to let me know what could be improved.

…are existing

dreispt

LGTM but made a few comements

dreispt · 2017-08-11T13:46:54Z

maintenance_plan/models/maintenance.py

+        })
+
+    @api.model
+    def _cron_generate_requests(self):


If this is to be used by a Cron it is an external API, so the name method should not start with an underscore.
Furthermore, I can see this used in a Button somewhere, so I suggest renaming it to "do_generate_requests" and expand the docstring to explain that ii can bu used by a cron job.

Thanks for your review.
However, as this method is called by standard ir.cron from maintenance module, I suppose it's better to leave its name as it is, so we don't have to update the existing ir.cron :
https://github.com/odoo/odoo/blob/10.0/addons/maintenance/data/maintenance_cron.xml#L10

I see, OK then.

dreispt · 2017-08-11T13:49:32Z

maintenance_plan/views/maintenance.xml

+    <record id="maintenance_kind_view_search" model="ir.ui.view">
+        <field name="name">maintenance.kind.search</field>
+        <field name="model">maintenance.kind</field>
+        <field name="arch" type="xml">


This view is redundant - Odoo does name searches by default.

dreispt · 2017-08-11T13:53:01Z

maintenance_plan/models/maintenance.py

+    def _create_new_request(self, maintenance_plan):
+        self.ensure_one()
+        self.env['maintenance.request'].create({
+            'name': _('Preventive Maintenance (%s) - %s') %


Please extract the dict creation into it's own _prepare_new_maintenance_request method, so that it is easy to extend it.

elicoidal

some details and one question on contraint

elicoidal · 2017-08-16T12:52:19Z

maintenance_plan/__manifest__.py

+# Copyright 2017 Camptocamp SA
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+{'name': 'Maintenance Plan',
+ 'version': '10.0.1.0.0',


a summary would be welcome

elicoidal · 2017-08-16T12:55:18Z

maintenance_plan/hooks.py

+                    "You have multiple preventive maintenance requests on an "
+                    "equipment's next action date. Please leave only one "
+                    "request as preventive on the date of equipment's next "
+                    "action to install the module."))


Nice to have: indicate which record are faulty

elicoidal · 2017-08-16T12:55:44Z

maintenance_plan/models/maintenance.py

+
+    _sql_constraints = [
+        ('name_uniq', 'unique (name)',
+         "Maintenance kind name already exists !")]


remove exclamation mark

elicoidal · 2017-08-16T13:04:36Z

maintenance_plan/models/maintenance.py

+                date_gap = fields.Date.from_string(
+                    next_maintenance_todo.request_date) - \
+                    fields.Date.from_string(last_maintenance_done.close_date)
+                # If the gap between the last_maintenance_done and the


This look like specific rule that might not apply everywhere

@elicoidal Thanks for your review.

This code is an adaptation from odoo to keep the behaviour as close as possible to standard module : https://github.com/odoo/odoo/blob/10.0/addons/maintenance/models/maintenance.py#L165

elicoidal · 2017-08-16T13:22:42Z

maintenance_plan/models/maintenance.py

+    _sql_constraints = [
+        ('equipment_kind_uniq', 'unique (equipment_id, maintenance_kind_id)',
+         "You cannot define multiple times the same maintenance kind on an "
+         "equipment maintenance plan!")]


please remove exclamation mark.

dreispt · 2017-08-22T15:31:18Z

@elicoidal can you review the changes please?

Create maintenance_plan module

07a2f54

grindtildeath force-pushed the add_maintenance_plan branch from dddec62 to 07a2f54 Compare June 9, 2017 09:23

grindtildeath added 2 commits June 16, 2017 12:26

Add post-init hook

c403758

Display maintenance kind on request

06d8d54

grindtildeath force-pushed the add_maintenance_plan branch from dd33d59 to 06d8d54 Compare June 16, 2017 10:26

dreispt added the needs review label Jun 16, 2017

dreispt added this to the 10.0 milestone Jun 16, 2017

dreispt requested review from dreispt and pedrobaeza June 16, 2017 16:48

grindtildeath force-pushed the add_maintenance_plan branch from c7bfb04 to 63e332e Compare August 9, 2017 13:53

Require maintenance team on equipments if there is a maintenance plan

e35b7e6

grindtildeath force-pushed the add_maintenance_plan branch from 63e332e to e35b7e6 Compare August 9, 2017 13:59

grindtildeath added 2 commits August 9, 2017 16:03

Improve error message

cb819cc

Delete maintenance plans if an equipment is deleted

1e238a7

grindtildeath force-pushed the add_maintenance_plan branch from 4d41b53 to 5fa2521 Compare August 10, 2017 11:33

grindtildeath added 2 commits August 10, 2017 15:47

Restrict deletion of maintenance plan if undone requests of its kind …

1462561

…are existing

Restrict deletion of maintenance kinds

c2b47a8

grindtildeath force-pushed the add_maintenance_plan branch from 5fa2521 to c2b47a8 Compare August 10, 2017 13:49

dreispt reviewed Aug 11, 2017

View reviewed changes

grindtildeath added 2 commits August 14, 2017 10:51

Allow to prepare new requests from plan

4f1150b

Remove unneeded view on maintenance kind

7440877

dreispt approved these changes Aug 16, 2017

View reviewed changes

elicoidal suggested changes Aug 16, 2017

View reviewed changes

Add summary and improve error messages

819757b

dalonsod referenced this pull request in solvosci/maintenance Jul 8, 2019

[ADD] maintenance_plan module (#2)

0b81d5a

NuriaXifre pushed a commit to ForgeFlow/maintenance that referenced this pull request Jan 13, 2020

[ADD] maintenance_plan module (OCA#2)

b254513

NuriaXifre pushed a commit to ForgeFlow/maintenance that referenced this pull request Jan 13, 2020

[ADD] maintenance_plan module (OCA#2)

b84706f

NuriaXifre pushed a commit to ForgeFlow/maintenance that referenced this pull request Jan 13, 2020

[ADD] maintenance_plan module (OCA#2)

1c131a3

NuriaXifre pushed a commit to ForgeFlow/maintenance that referenced this pull request Jan 13, 2020

[ADD] maintenance_plan module (OCA#2)

116c8d6

NuriaXifre pushed a commit to ForgeFlow/maintenance that referenced this pull request Jan 14, 2020

[ADD] maintenance_plan module (OCA#2)

9f3cf4a

NuriaXifre pushed a commit to ForgeFlow/maintenance that referenced this pull request Feb 4, 2020

[ADD] maintenance_plan module (OCA#2)

3d92265

OCA-git-bot pushed a commit that referenced this pull request Nov 17, 2020

[ADD] maintenance_plan module (#2)

7d7cff3

BernatPForgeFlow pushed a commit to ForgeFlow/maintenance that referenced this pull request Oct 22, 2021

[ADD] maintenance_plan module (OCA#2)

70cff64

FernandoRomera pushed a commit to MallorcaSoft/maintenance that referenced this pull request Dec 9, 2022

[ADD] maintenance_plan module (OCA#2)

561c978

FernandoRomera pushed a commit to MallorcaSoft/maintenance that referenced this pull request Dec 20, 2022

[ADD] maintenance_plan module (OCA#2)

c2405c8

vibhascs pushed a commit to vibhascs/maintenance that referenced this pull request Jan 13, 2023

[ADD] maintenance_plan module (OCA#2)

7b61623

YvanDotet pushed a commit to YvanDotet/maintenance that referenced this pull request Mar 23, 2023

[ADD] maintenance_plan module (OCA#2)

6ad019d

alexeirivera87 pushed a commit to archeti-org/maintenance that referenced this pull request Jun 14, 2023

[ADD] maintenance_plan module (OCA#2)

1946eeb

brian10048 pushed a commit to brian10048/maintenance that referenced this pull request Nov 22, 2023

[ADD] maintenance_plan module (OCA#2)

be982b2

renda-dev pushed a commit to PyTech-SRL/maintenance that referenced this pull request Nov 27, 2023

[ADD] maintenance_plan module (OCA#2)

8c11c0e

alexeirivera87 pushed a commit to archeti-org/maintenance that referenced this pull request Jan 30, 2024

[ADD] maintenance_plan module (OCA#2)

d702b52

alexeirivera87 pushed a commit to archeti-org/maintenance that referenced this pull request Feb 1, 2024

[ADD] maintenance_plan module (OCA#2)

cc84b0e

FernandoRomera pushed a commit to FernandoRomera/maintenance that referenced this pull request Jul 23, 2024

[ADD] maintenance_plan module (OCA#2)

d296e6c

BhaveshHeliconia pushed a commit to HeliconiaIO/maintenance that referenced this pull request Jan 27, 2025

[ADD] maintenance_plan module (OCA#2)

ea93571

gbrito pushed a commit to gbrito/maintenance that referenced this pull request Oct 3, 2025

[ADD] maintenance_plan module (OCA#2)

e41171d

ypapouin pushed a commit to decgroupe/maintenance that referenced this pull request Oct 28, 2025

[ADD] maintenance_plan module (OCA#2)

e94ac30

ypapouin pushed a commit to decgroupe/maintenance that referenced this pull request Oct 28, 2025

[ADD] maintenance_plan module (OCA#2)

26d08ed

ypapouin pushed a commit to decgroupe/maintenance that referenced this pull request Oct 28, 2025

[ADD] maintenance_plan module (OCA#2)

1fe3e59

ypapouin pushed a commit to decgroupe/maintenance that referenced this pull request Oct 28, 2025

[ADD] maintenance_plan module (OCA#2)

86e44a3

ypapouin pushed a commit to decgroupe/maintenance that referenced this pull request Oct 29, 2025

[ADD] maintenance_plan module (OCA#2)

ffbb1d3

ypapouin pushed a commit to decgroupe/maintenance that referenced this pull request Nov 21, 2025

[ADD] maintenance_plan module (OCA#2)

4d0479e

JasminSForgeFlow pushed a commit to ForgeFlow/maintenance that referenced this pull request Nov 26, 2025

[ADD] maintenance_plan module (OCA#2)

9f72d63

JasminSForgeFlow pushed a commit to ForgeFlow/maintenance that referenced this pull request Dec 3, 2025

[ADD] maintenance_plan module (OCA#2)

df52855

JasminSForgeFlow pushed a commit to ForgeFlow/maintenance that referenced this pull request Dec 23, 2025

[ADD] maintenance_plan module (OCA#2)

aec157c

Uh oh!

[ADD] maintenance_plan module #2

[ADD] maintenance_plan module #2

Uh oh!

Conversation

grindtildeath commented Jun 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

================ Maintenance Plan

Installation

Usage

Uh oh!

dreispt commented Jun 9, 2017

Uh oh!

grindtildeath commented Jun 9, 2017

Uh oh!

dreispt commented Jun 9, 2017

Uh oh!

dreispt commented Jun 9, 2017

Uh oh!

grindtildeath commented Jun 16, 2017

Uh oh!

dreispt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elicoidal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dreispt commented Aug 22, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

grindtildeath commented Jun 9, 2017 •

edited

Loading

================
Maintenance Plan