[10.0][ADD] Module maintenance_equipment_scrap #4

espo-tony · 2017-06-09T12:26:02Z

This module improves the action of scrapping an equipment, sending a message and automatically setting the scrap date when the action is performed.

pedrobaeza · 2017-06-09T12:37:03Z

maintenance_equipment_scrap/README.rst

+
+To configure this module, you need to:
+
+#. Go to 'Settings' -> 'Technical' -> 'Email' -> 'Templates' and create a new template you wish to use for equipment scrapping notifications


Don't you provide a default template?

In my latest commit I provide it.

Then change this README for telling about that.

pedrobaeza · 2017-06-09T12:37:45Z

maintenance_equipment_scrap/models/maintenance_equipment.py

+
+    _inherit = 'maintenance.equipment'
+
+    asset_id = fields.Many2one('account.asset.asset', string='Asset')


Why adding this field?

You're perfectly right. It was a mistake.

- Removed unrequired method extensions; - The Scrap Template configuration is now done in the Stock Configuration (previously on the Accounting Configuration); - Added dependency to Stock module;

dreispt · 2017-06-09T16:44:04Z

maintenance_equipment_scrap/__manifest__.py

+{
+    'name': 'Maintenance Equipments Scrap',
+    'summary': 'Enhance the functionality for Scrapping Equipments',
+    'author': 'Onestein',


dreispt · 2017-06-09T16:44:20Z

maintenance_equipment_scrap/__manifest__.py

+    'summary': 'Enhance the functionality for Scrapping Equipments',
+    'author': 'Onestein',
+    'website': 'http://www.onestein.eu',
+    'category': 'Human Resources',


Maintenance?

I picked the same category of the Odoo base module 'maintenance', just for keeping consistency with it, but it's fine for me to change it. What do you think?

dreispt · 2017-06-09T16:46:08Z

maintenance_equipment_scrap/models/res_company.py

+    equipment_scrap_template_id = fields.Many2one(
+        'mail.template',
+        string='Equipment Scrap Email Template'
+    )


What do you think about having the Template the a Equipment category level instead (or also)?

I think it could be a good idea. Maybe the best is adding it on the Equipment category in order to be automatically proposed on the equipment when its category changes?

Yes, that could work.

dreispt · 2017-06-09T16:48:55Z

maintenance_equipment_scrap/models/maintenance_equipment.py

+            'maintenance_equipment_scrap.wizard_perform_equipment_scrap_action'
+        )
+        result = action.read()[0]
+        return result


This module is just about sending an email when you click on a button?
Don't take me wrong but it sounds shallow - a quick Automated Action can do just the same.
Shouldn't we somehow also mark the Equipment as inactive?

This module "actively" only does two things:

Sends an email when a scrap is performed, and only if on the equipment is selected a scrapping template;

Writes the scrap_date field when a scrap is performed.

Still, I think that what really makes this module useful is that it provides a structure for the equipment scrapping functionality. To better explain, consider that in base Odoo, the equipment scrapping functionality just doesn't exist: as far as I can see, an equipment is considered scrapped when the user manually set a scrap date; there is no state change, no active/inactive switch, nothing else that says that a given equipment is scrapped.
Because of this lack of structure, it's quite tricky to define additional logics to be ran when an equipment is scrapped (such logic as, for exemple, to send an email when it occurs).

This module makes the scrap_date field read-only and provides a procedure for a user to scrap an equipment: it has to click the "scrap" button, to fill a form and finally to submit it. This provides, apart from the obvious functionality of sending an email, an entry-point for adding more and more logic (making the equipment inactive is a possible example, as it could be making some changes on the related asset, or whatever else we can think about, and that could be added in this or in other, more specific-purpose, modules).

What do you think about that?

OK, thanks for the explanation. Indeed it is a good step forward.
I'm pretty sure we also need a Stage/State, but I agree that it could be left for a later PR.
In case you are willing to add that, I strongly suggest reusing the oca/server-tools base_stage_state module.

dreispt · 2017-06-12T08:19:12Z

maintenance_equipment_scrap/__manifest__.py

+    'depends': [
+        'maintenance',
+        'mail',
+        'stock',


I can see that you added the Stock dependency to be able to add a Settings option.
You thought well, but I think that this is a too heavy dependency.
I would prefer to have it removed, even if that also means dropping the Settings option for now.
ideally, we could have a "maintenance_settings" module, providing the missing Settings menu for the Maintenance app, and then we could add this option there.
What do you think?

I confess I was quite doubtful about using the stock settings for this, deciding for it just because there isn't a default maintenance settings functionality to use nor I thought it was the case to add it within this module.
Therefore I'm in favor of dropping the settings option for now, looking for a further module that provides a Maintenance functionality.

- Removed settings option; - Removed dependency from module stock; - Added equipment scrap mail template on equipment category; - On equipments, when the category changes, the equipment scrap mail template is loaded from the new category; - Added test for the onchange functionality; - Fixed year in the headers;

espo-tony · 2017-06-12T11:59:46Z

@dreispt
As agreed, I removed the settings option altogether with the 'stock' dependency; Moreover I added the mail template also on category level, automatically loading it when the category is changed on the equipment.

@pedrobaeza
Please, can you check the latest updates?

espo-tony · 2017-06-19T10:01:32Z

@pedrobaeza
Can I ask you to review the changes you requested on this PR? Thank you in advance

elicoidal

LGTM

elicoidal · 2017-06-20T01:13:23Z

@pedrobaeza I think your comments were attended and we could move forward.

[10.0][ADD] Module maintenance_equipment_scrap

a5146aa

This module improves the action of scrapping an equipment, sending a message and automatically setting the scrap date when the action is performed.

pedrobaeza requested changes Jun 9, 2017

View reviewed changes

espo-tony added 4 commits June 9, 2017 14:41

[FIX] Removed unused field

efc351b

[FIX] Removed unused field from view

6104d95

[ADD] Created a default mail template for equipment scrapping

3495804

[FIX] Several fixes:

6a18fbc

- Removed unrequired method extensions; - The Scrap Template configuration is now done in the Stock Configuration (previously on the Accounting Configuration); - Added dependency to Stock module;

dreispt reviewed Jun 9, 2017

View reviewed changes

[FIX] Added OCA as author

2918b72

dreispt reviewed Jun 12, 2017

View reviewed changes

dreispt approved these changes Jun 12, 2017

View reviewed changes

[FIX] Updated 'Configuration' section in readme file

0b8186e

astirpe approved these changes Jun 19, 2017

View reviewed changes

elicoidal approved these changes Jun 20, 2017

View reviewed changes

pedrobaeza approved these changes Jun 20, 2017

View reviewed changes

pedrobaeza merged commit d290102 into OCA:10.0 Jun 20, 2017

espo-tony mentioned this pull request Jun 20, 2017

[10.0][ADD] Module maintenance_settings #5

Merged

espo-tony mentioned this pull request Jul 12, 2017

[10.0][ADD] Module account_asset_maintenance OCA/account-financial-tools#461

Closed

dalonsod pushed a commit to solvosci/maintenance that referenced this pull request Jul 3, 2019

[10.0][ADD] Module maintenance_equipment_scrap (OCA#4)

7bc8085

OCA-git-bot pushed a commit that referenced this pull request Jul 8, 2019

[10.0][ADD] Module maintenance_equipment_scrap (#4)

767e929

dalonsod pushed a commit to solvosci/maintenance that referenced this pull request Jul 9, 2019

[10.0][ADD] Module maintenance_equipment_scrap (OCA#4)

ab2eb03

OCA-git-bot pushed a commit that referenced this pull request Jul 26, 2019

[10.0][ADD] Module maintenance_equipment_scrap (#4)

5d543a4

mariadforgeflow pushed a commit to ForgeFlow/maintenance that referenced this pull request Aug 19, 2021

[10.0][ADD] Module maintenance_equipment_scrap (OCA#4)

52bcd3f

mariadforgeflow pushed a commit to ForgeFlow/maintenance that referenced this pull request Sep 23, 2021

[10.0][ADD] Module maintenance_equipment_scrap (OCA#4)

d7860aa

mymage pushed a commit to mymage/maintenance that referenced this pull request Nov 24, 2022

[10.0][ADD] Module maintenance_equipment_scrap (OCA#4)

23b07fe

ypapouin pushed a commit to decgroupe/maintenance that referenced this pull request Oct 14, 2025

[10.0][ADD] Module maintenance_equipment_scrap (OCA#4)

ada1f92


		To configure this module, you need to:

		#. Go to 'Settings' -> 'Technical' -> 'Email' -> 'Templates' and create a new template you wish to use for equipment scrapping notifications


		_inherit = 'maintenance.equipment'

		asset_id = fields.Many2one('account.asset.asset', string='Asset')

Uh oh!

[10.0][ADD] Module maintenance_equipment_scrap #4

[10.0][ADD] Module maintenance_equipment_scrap #4

Uh oh!

Conversation

espo-tony commented Jun 9, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

espo-tony commented Jun 12, 2017

Uh oh!

espo-tony commented Jun 19, 2017

Uh oh!

elicoidal left a comment

Choose a reason for hiding this comment

Uh oh!

elicoidal commented Jun 20, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants