Skip to content

[19.0][MIG] maintenance_equipment_certification#548

Merged
OCA-git-bot merged 10 commits into
OCA:19.0from
ForgeFlow:19.0-mig-maintenance_equipment_certification
Apr 21, 2026
Merged

[19.0][MIG] maintenance_equipment_certification#548
OCA-git-bot merged 10 commits into
OCA:19.0from
ForgeFlow:19.0-mig-maintenance_equipment_certification

Conversation

@JasminSForgeFlow
Copy link
Copy Markdown

@JasminSForgeFlow JasminSForgeFlow commented Mar 20, 2026 •
edited
Loading

Standard Migration

Below things are improved in module, not a part of migration

  • Add certificate number and renewal date
  • Add dedicated menu for certificate
  • Send an email notification when a certificate is about to expire
  • Configure how many days before need to send email, it can be multiple ( i.e. 20 days before, 10 days before)
  • Add active/inactive feature

@ForgeFlow

@JasminSForgeFlow JasminSForgeFlow force-pushed the 19.0-mig-maintenance_equipment_certification branch from dbf9979 to f850418 Compare March 20, 2026 09:55
AaronHForgeFlow
AaronHForgeFlow approved these changes Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Functional + code

@JasminSForgeFlow JasminSForgeFlow force-pushed the 19.0-mig-maintenance_equipment_certification branch from f850418 to ac05404 Compare March 23, 2026 09:01
MarinaAForgeFlow
MarinaAForgeFlow approved these changes Mar 23, 2026
View reviewed changes
Copy link
Copy Markdown

@MarinaAForgeFlow MarinaAForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review. LGTM

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Mar 25, 2026

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

BhaveshHeliconia
BhaveshHeliconia approved these changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM!

@JasminSForgeFlow JasminSForgeFlow force-pushed the 19.0-mig-maintenance_equipment_certification branch 3 times, most recently from 3d82186 to cb12c26 Compare April 2, 2026 09:03
AaronHForgeFlow
AaronHForgeFlow reviewed Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpickings after the latest improvements

Comment thread maintenance_equipment_certification/tests/test_maintenance_equipment_certification.py Outdated
Comment on lines +70 to +72
# ------------------------------------------------------------------
# Helpers
# ------------------------------------------------------------------
Copy link
Copy Markdown
Contributor

@AaronHForgeFlow AaronHForgeFlow Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this section comments are too big IMHO can you just remove them or make them smaller?

Copy link
Copy Markdown
Author

@JasminSForgeFlow JasminSForgeFlow Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated thanks

Comment thread maintenance_equipment_certification/tests/test_maintenance_equipment_certification.py Outdated
# Cron – single rule
# ------------------------------------------------------------------

def test_cron_creates_notification_for_expiring_certificate(self):
Copy link
Copy Markdown
Contributor

@AaronHForgeFlow AaronHForgeFlow Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you consolidate all these tests into 2-3 tests that checks end to end flows?

Copy link
Copy Markdown
Author

@JasminSForgeFlow JasminSForgeFlow Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated thanks

@JasminSForgeFlow JasminSForgeFlow force-pushed the 19.0-mig-maintenance_equipment_certification branch from cb12c26 to fbe04f0 Compare April 13, 2026 05:34
@JasminSForgeFlow JasminSForgeFlow force-pushed the 19.0-mig-maintenance_equipment_certification branch from fbe04f0 to 2d95c5e Compare April 13, 2026 05:41
etobella
etobella approved these changes Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/ocabot migration maintenance_equipment_certification

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Apr 21, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 21, 2026
Open
20 tasks
@etobella
Copy link
Copy Markdown
Member

etobella commented Apr 21, 2026

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Apr 21, 2026

This PR looks fantastic, let's merge it!
Prepared branch 19.0-ocabot-merge-pr-548-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7a99144 into OCA:19.0 Apr 21, 2026
5 of 7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Apr 21, 2026

Congratulations, your PR was merged at 69864f3. Thanks a lot for contributing to OCA. ❤️

@JasminSForgeFlow JasminSForgeFlow deleted the 19.0-mig-maintenance_equipment_certification branch May 14, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etobella etobella etobella approved these changes

+3 more reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@MarinaAForgeFlow MarinaAForgeFlow MarinaAForgeFlow approved these changes

@BhaveshHeliconia BhaveshHeliconia BhaveshHeliconia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

19.0

Development

Successfully merging this pull request may close these issues.

8 participants

@JasminSForgeFlow @OCA-git-bot @etobella @AaronHForgeFlow @MarinaAForgeFlow @BhaveshHeliconia @cubells @mymage