Skip to content

[14.0][MIG] mgmtsystem partner#445

Merged
OCA-git-bot merged 2 commits intoOCA:14.0from
mymage:14.0-mig-mgmtsystem_partner
Nov 13, 2022
Merged

[14.0][MIG] mgmtsystem partner#445
OCA-git-bot merged 2 commits intoOCA:14.0from
mymage:14.0-mig-mgmtsystem_partner

Conversation

@mymage
Copy link
Copy Markdown
Member

@mymage mymage commented Nov 6, 2022

Migration to 14.0

@mymage mymage force-pushed the 14.0-mig-mgmtsystem_partner branch from f358b73 to 6822611 Compare November 6, 2022 19:44
@mymage mymage mentioned this pull request Nov 6, 2022
Open
27 tasks
@mymage mymage force-pushed the 14.0-mig-mgmtsystem_partner branch 3 times, most recently from d63821d to 7278005 Compare November 6, 2022 22:18
@ivantodorovich
Copy link
Copy Markdown
Contributor

ivantodorovich commented Nov 7, 2022

Could you check the commit history?
Seems the commits from 13.0 are missing here

https://github.com/OCA/management-system/commits/13.0/mgmtsystem_partner

@mymage
Copy link
Copy Markdown
Member Author

mymage commented Nov 7, 2022 •
edited
Loading

Could you check the commit history?

I'm quite sure to had done some mistake and squashed too many commit...
I'm not expert: it is better if I close this PR and do a new one?

@ivantodorovich
Copy link
Copy Markdown
Contributor

ivantodorovich commented Nov 7, 2022

You can always start from scratch and push --force again to this branch. Then there's no need to create a new PR :)

@max3903 max3903 added this to the 14.0 milestone Nov 7, 2022
@max3903
Copy link
Copy Markdown
Member

max3903 commented Nov 7, 2022

/ocabot migration mgmtsystem_partner

@mymage mymage force-pushed the 14.0-mig-mgmtsystem_partner branch from 7278005 to 0b4b8c2 Compare November 10, 2022 18:53
@max3903 max3903 self-assigned this Nov 10, 2022
max3903
max3903 reviewed Nov 10, 2022
View reviewed changes
Comment thread mgmtsystem_partner/models/mgmtsystem_partner.py
_inherit = ["res.partner"]

# type for manage quality contact
type = fields.Selection(selection_add=[("quality", "Quality Address")])
Copy link
Copy Markdown
Member

@max3903 max3903 Nov 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mymage Please rename this file res_partner.py to match the model.

max3903
max3903 reviewed Nov 10, 2022
View reviewed changes
Comment thread mgmtsystem_partner/models/mgmtsystem_partner.py Outdated
from odoo import fields, models


class PartnerReference(models.Model):
Copy link
Copy Markdown
Member

@max3903 max3903 Nov 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class PartnerReference(models.Model):
class ResPartner(models.Model):

@mymage mymage force-pushed the 14.0-mig-mgmtsystem_partner branch from 0b4b8c2 to 3c08371 Compare November 13, 2022 15:58
@mymage
Copy link
Copy Markdown
Member Author

mymage commented Nov 13, 2022

@max3903 all done

@max3903
Copy link
Copy Markdown
Member

max3903 commented Nov 13, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Nov 13, 2022

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-445-by-max3903-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 19e219c into OCA:14.0 Nov 13, 2022
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Nov 13, 2022

Congratulations, your PR was merged at fe75271. Thanks a lot for contributing to OCA. ❤️

@mymage mymage deleted the 14.0-mig-mgmtsystem_partner branch December 17, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max3903 max3903 max3903 approved these changes

Assignees

@max3903 max3903

Labels

merged 🎉 migration needs review

Projects

None yet

Milestone

14.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mymage @ivantodorovich @max3903 @OCA-git-bot