Skip to content

[IMP] Add date/time of report generation in XLS export (issue #191)#193

Merged
OCA-git-bot merged 1 commit intoOCA:10.0from
acsone:feature/10.0-issue-191
Jun 24, 2019
Merged

[IMP] Add date/time of report generation in XLS export (issue #191)#193
OCA-git-bot merged 1 commit intoOCA:10.0from
acsone:feature/10.0-issue-191

Conversation

@apineux
Copy link
Copy Markdown
Contributor

@apineux apineux commented May 10, 2019 •
edited by sbidoul
Loading

closes #191

@oca-clabot
Copy link
Copy Markdown

oca-clabot commented May 10, 2019

Hey @apineux, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@sbidoul
Copy link
Copy Markdown
Member

sbidoul commented May 10, 2019

@apineux is covered by the ACSONE ECLA.

sbidoul
sbidoul reviewed May 10, 2019
View reviewed changes
Comment thread mis_builder/report/mis_report_instance_xlsx.py Outdated
@sbidoul
Copy link
Copy Markdown
Member

sbidoul commented May 10, 2019

Can you also add a file named 191.feature in readme/newfragments. This project uses towncrier to generate the changelog.

@sbidoul sbidoul mentioned this pull request May 13, 2019
Closed
@sbidoul
Copy link
Copy Markdown
Member

sbidoul commented May 16, 2019

The newfragment should contain the changelog entry as a short paragraph;

sbidoul
sbidoul requested changes May 16, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better way to get local time

@apineux apineux force-pushed the feature/10.0-issue-191 branch from e6bf0b9 to 97d8542 Compare May 17, 2019 10:03
@apineux
Copy link
Copy Markdown
Contributor Author

apineux commented Jun 20, 2019

@sbidoul Can you validate (or unvalidate) this development? Thanks

@sbidoul sbidoul force-pushed the feature/10.0-issue-191 branch from 97d8542 to a05a2ca Compare June 24, 2019 17:54
@sbidoul
Copy link
Copy Markdown
Member

sbidoul commented Jun 24, 2019 •
edited
Loading

Squashed. Please /ocabot merge

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jun 24, 2019

On my way to merge this fine PR!
Rebased to 10.0-ocabot-merge-pr-193-by-sbidoul-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a05a2ca into OCA:10.0 Jun 24, 2019
OCA-git-bot added a commit that referenced this pull request Jun 24, 2019
@OCA-git-bot
Merge PR #193 into 10.0
413b5d7 
Signed-off-by sbidoul
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jun 24, 2019

Congratulations, your PR was merged at 413b5d7. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 10.0.

@sbidoul sbidoul deleted the feature/10.0-issue-191 branch June 25, 2019 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbidoul sbidoul sbidoul approved these changes

Assignees

No one assigned

Labels

enhancement merged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add date/time of report generation in XLS export

4 participants

@apineux @oca-clabot @sbidoul @OCA-git-bot