[IMP] Hide sensitive or bloated data in logs#107
Merged
sebalix merged 1 commit intoOCA:masterfrom Apr 13, 2026
Merged
Conversation
4392e6a to
786d531
Compare
|
I like this approach! |
Two new classes are provided acting as replacement for string values: - `odoorpc.rpc.jsonrpclib.Secret` - `odoorpc.rpc.jsonrpclib.Bloat` When such objects are detected in the data sent by RPC, they are replaced by their `.MASK` value. While used internally by OdooRPC to hide password and bloated data, these classes can also be used by the user to hide any sensitive data in its own payloads.
786d531 to
d8e39ae
Compare
Collaborator
Author
|
Merging 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #103 and fix #70.
Two new classes are provided acting as replacement for string values:
odoorpc.rpc.jsonrpclib.Secretodoorpc.rpc.jsonrpclib.BloatWhen such objects are detected in the data sent by RPC, they are replaced by their
.MASKvalue.While used internally by OdooRPC to hide password and bloated data, these classes can also be used by the user to hide any sensitive data in its own payloads.
NOTE: I'm not able to test this with Python 2, but I should drop such support anyway (the CI isn't running it for quite some time now).