Skip to content

[IMP] Hide sensitive or bloated data in logs#107

Merged
sebalix merged 1 commit intoOCA:masterfrom
sebalix:hide-data-in-logs
Apr 13, 2026
Merged

[IMP] Hide sensitive or bloated data in logs#107
sebalix merged 1 commit intoOCA:masterfrom
sebalix:hide-data-in-logs

Conversation

@sebalix
Copy link
Copy Markdown
Collaborator

@sebalix sebalix commented Apr 13, 2026

Supersedes #103 and fix #70.

Two new classes are provided acting as replacement for string values:

  • odoorpc.rpc.jsonrpclib.Secret
  • odoorpc.rpc.jsonrpclib.Bloat

When such objects are detected in the data sent by RPC, they are replaced by their .MASK value.

While used internally by OdooRPC to hide password and bloated data, these classes can also be used by the user to hide any sensitive data in its own payloads.

NOTE: I'm not able to test this with Python 2, but I should drop such support anyway (the CI isn't running it for quite some time now).

@sebalix sebalix added this to the v0.11.0 milestone Apr 13, 2026
@sebalix sebalix marked this pull request as ready for review April 13, 2026 11:19
@sebalix sebalix force-pushed the hide-data-in-logs branch from 4392e6a to 786d531 Compare April 13, 2026 11:21
@spaceone
Copy link
Copy Markdown

I like this approach!

Two new classes are provided acting as replacement for string values:
- `odoorpc.rpc.jsonrpclib.Secret`
- `odoorpc.rpc.jsonrpclib.Bloat`

When such objects are detected in the data sent by RPC, they are replaced
by their `.MASK` value.

While used internally by OdooRPC to hide password and bloated data, these
classes can also be used by the user to hide any sensitive data in
its own payloads.
@sebalix sebalix force-pushed the hide-data-in-logs branch from 786d531 to d8e39ae Compare April 13, 2026 11:33
@sebalix
Copy link
Copy Markdown
Collaborator Author

sebalix commented Apr 13, 2026

Merging 🙏

@sebalix sebalix merged commit eb65a4f into OCA:master Apr 13, 2026
13 checks passed
@sebalix sebalix deleted the hide-data-in-logs branch April 13, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Password is logged in clear text

2 participants