[16.0][IMP] partner_company_type: allow to set up countries and states, display shortcut in name #1604

OriolMForgeFlow · 2023-11-16T10:23:12Z

No description provided.

JordiMForgeFlow

Code review LGTM

github-actions · 2024-05-12T12:32:42Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

AaronHForgeFlow

Code review LG

LoisRForgeFlow

Code review 👍

github-actions · 2024-09-22T12:37:52Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

JordiMForgeFlow · 2024-09-25T10:09:43Z

@rousseldenis could we get a review here? :)

rousseldenis · 2024-12-06T11:05:46Z

@OriolMForgeFlow @len-foss Isn't it the same problematic ?

#1917

I would say I'd prefer an EXCLUDE

rousseldenis · 2024-12-06T11:04:24Z

partner_company_type/models/res_partner.py

+                rec.partner_company_type_id.country_ids
+                and rec.country_id not in rec.partner_company_type_id.country_ids
+            ):
+                raise UserError(


You should raise ValidationErrorin a contraint.

@rousseldenis corrected :)

len-foss · 2024-12-06T20:26:54Z

@rousseldenis
#1917 is to relax the name check to allow the same name to be used for 2 different country (which I assume would speak the same language, which isn't so rare in the world), which isn't actually done here.

Here there's a check to choose a company type to match the partner's country which is nice though.

Since it seems that different use-cases want for different constraint, it would make sense to have a configuration option to choose what is allowed. Therefore entirely drop the sql constaint for the python check.

github-actions · 2025-04-13T12:41:33Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

JordiMForgeFlow · 2025-04-14T06:39:10Z

@len-foss @rousseldenis could we get this one merged?

JordiMForgeFlow · 2025-08-08T09:07:36Z

@rousseldenis could we move this one forward?

NL66278 · 2025-09-15T14:04:19Z

partner_company_type/models/res_partner.py

+    def _check_partner_company_type_country_state(self):
+        for rec in self:
+            if not rec.partner_company_type_id:
+                return


Should this not be continue?

NL66278

This are very extensive changes without any reflection in the README. To me it is completely unclear what problem this PR is supposed to solve.

JordiMForgeFlow · 2025-09-15T14:58:42Z

@NL66278 you are right, README is now updated to reflect the purpose.

We don't have a problem with the module, we are simply proposing an improvement in order to manage the relation of Legal Forms with countries and their states. Legal Forms are very structured and predefined in most countries so it is a way to ensure and validate that the data is correct.

NL66278 · 2025-09-16T08:14:21Z

@JordiMForgeFlow It is becoming more clear now. Would it be possible to consistently use the vocabulary of "Legal Entity Type" instead of Legal Form. The word "Form" is confusing at it suggest some kind of document or form that must be filled.

JordiMForgeFlow · 2025-09-16T08:25:51Z

@NL66278 done :)

NL66278 · 2025-09-16T14:45:58Z

partner_company_type/migrations/16.0.1.0.1/post-migration.py

@@ -0,0 +1,11 @@
+# Copyright 2023 ForgeFlow S.L. <http://www.forgeflow.com>
+# License LGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).


The module itself has an AGPL license.

NL66278 · 2025-09-16T14:47:24Z

partner_company_type/views/res_partner.xml

                    name="partner_company_type_id"
                    options='{"no_open": True}'
                    attrs="{'invisible': [('is_company', '=', False)]}"
+                    domain="[ '|', ('country_ids', '=', False), ('country_ids', 'in', [country_id]), '|', ('state_ids', '=', False), ('state_ids', 'in', [state_id])]"


This can actually be split over multiple lines, would be nicer.

NL66278 · 2025-09-16T14:48:03Z

Two last small remarks and we should be good to go.

…play shortcut in name

JordiMForgeFlow · 2025-09-16T14:57:46Z

@NL66278 thank you for the reviews, should be now ready :)

NL66278

👍 Thanks for your contribution! LGTM

NL66278 · 2025-09-16T15:09:55Z

/ocabot merge major

OCA-git-bot · 2025-09-16T15:10:02Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1604-by-NL66278-bump-major, awaiting test results.

OCA-git-bot · 2025-09-16T15:19:44Z

Congratulations, your PR was merged at 820958d. Thanks a lot for contributing to OCA. ❤️

OriolMForgeFlow force-pushed the 16.0-imp-partner_company_type branch 5 times, most recently from 944bccc to 914e55c Compare November 17, 2023 09:18

This was referenced Nov 17, 2023

[WIP][16.0][ADD] partner_company_type_elf #1603

Closed

[16.0][ADD] partner_entity_legal_form #1594

Closed

OriolMForgeFlow force-pushed the 16.0-imp-partner_company_type branch 2 times, most recently from 44a8411 to 5350466 Compare November 17, 2023 10:50

JordiMForgeFlow approved these changes Nov 17, 2023

View reviewed changes

JordiMForgeFlow force-pushed the 16.0-imp-partner_company_type branch from 5350466 to 9c4d7ef Compare January 9, 2024 13:36

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 12, 2024

AaronHForgeFlow approved these changes May 13, 2024

View reviewed changes

OCA-git-bot added the approved label May 13, 2024

LoisRForgeFlow approved these changes May 13, 2024

View reviewed changes

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 19, 2024

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 22, 2024

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 29, 2024

rousseldenis reviewed Dec 6, 2024

View reviewed changes

JordiMForgeFlow force-pushed the 16.0-imp-partner_company_type branch from 9c4d7ef to ac966c5 Compare December 10, 2024 11:06

kevinkhao mentioned this pull request Jan 15, 2025

[18.0][MIG] partner_company_type: Migration to 18.0 #1959

Closed

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 13, 2025

JordiMForgeFlow force-pushed the 16.0-imp-partner_company_type branch from ac966c5 to 1068af9 Compare April 14, 2025 06:33

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 20, 2025

NL66278 reviewed Sep 15, 2025

View reviewed changes

NL66278 requested changes Sep 15, 2025

View reviewed changes

OCA-git-bot removed the approved label Sep 15, 2025

NL66278 added the needs more information label Sep 15, 2025

JordiMForgeFlow force-pushed the 16.0-imp-partner_company_type branch from 1068af9 to 73fa29e Compare September 15, 2025 14:56

MiquelRForgeFlow approved these changes Sep 15, 2025

View reviewed changes

JordiMForgeFlow force-pushed the 16.0-imp-partner_company_type branch from 73fa29e to cccddcb Compare September 16, 2025 08:25

NL66278 reviewed Sep 16, 2025

View reviewed changes

JordiMForgeFlow force-pushed the 16.0-imp-partner_company_type branch from cccddcb to e203008 Compare September 16, 2025 14:47

[IMP] partner_company_type: allow to set up countries and states, dis…

717b7ea

…play shortcut in name

JordiMForgeFlow force-pushed the 16.0-imp-partner_company_type branch from e203008 to 717b7ea Compare September 16, 2025 14:49

NL66278 approved these changes Sep 16, 2025

View reviewed changes

OCA-git-bot added the approved label Sep 16, 2025

OCA-git-bot added the bot is merging ⏳ label Sep 16, 2025

OCA-git-bot merged commit 86044ca into OCA:16.0 Sep 16, 2025
7 of 9 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Sep 16, 2025

MiquelRForgeFlow deleted the 16.0-imp-partner_company_type branch September 16, 2025 15:29

huguesdk mentioned this pull request Nov 10, 2025

[16.0][REF] cooperator: moving from legal_form to partner_company_type OCA/cooperative#167

Open

		@@ -0,0 +1,11 @@
		# Copyright 2023 ForgeFlow S.L. <http://www.forgeflow.com>
		# License LGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).

Uh oh!

[16.0][IMP] partner_company_type: allow to set up countries and states, display shortcut in name #1604

[16.0][IMP] partner_company_type: allow to set up countries and states, display shortcut in name #1604

Uh oh!

Conversation

OriolMForgeFlow commented Nov 16, 2023

Uh oh!

JordiMForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 12, 2024

Uh oh!

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

LoisRForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 22, 2024

Uh oh!

JordiMForgeFlow commented Sep 25, 2024

Uh oh!

rousseldenis commented Dec 6, 2024

Uh oh!

rousseldenis Dec 6, 2024

Choose a reason for hiding this comment

Uh oh!

JordiMForgeFlow Dec 10, 2024

Choose a reason for hiding this comment

Uh oh!

len-foss commented Dec 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 13, 2025

Uh oh!

JordiMForgeFlow commented Apr 14, 2025

Uh oh!

JordiMForgeFlow commented Aug 8, 2025

Uh oh!

NL66278 Sep 15, 2025

Choose a reason for hiding this comment

Uh oh!

NL66278 left a comment

Choose a reason for hiding this comment

Uh oh!

JordiMForgeFlow commented Sep 15, 2025

Uh oh!

NL66278 commented Sep 16, 2025

Uh oh!

JordiMForgeFlow commented Sep 16, 2025

Uh oh!

NL66278 Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

NL66278 Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

NL66278 commented Sep 16, 2025

Uh oh!

JordiMForgeFlow commented Sep 16, 2025

Uh oh!

NL66278 left a comment

Choose a reason for hiding this comment

Uh oh!

NL66278 commented Sep 16, 2025

Uh oh!

OCA-git-bot commented Sep 16, 2025

Uh oh!

OCA-git-bot commented Sep 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

len-foss commented Dec 6, 2024 •

edited

Loading