[17.0][MIG] payroll_account #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edescalona
force-pushed
the
17.0-mig-payroll_account
branch
from
d410263 to
7ed7f43
Compare
Currently translated at 100.0% (24 of 24 strings) Translation: payroll-14.0/payroll-14.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll_account/ca/
Currently translated at 16.6% (4 of 24 strings) Translation: payroll-14.0/payroll-14.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll_account/es_AR/
Currently translated at 100.0% (24 of 24 strings) Translation: payroll-14.0/payroll-14.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll_account/es_AR/
Currently translated at 100.0% (24 of 24 strings) Translation: payroll-14.0/payroll-14.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll_account/es/
…or the payslip Until now this module tried to confirm an empty account move. This caused the account module to throw an exception. This causes problems in other modules that may not know about payroll_account. For example in other modules' tests.
Currently translated at 100.0% (24 of 24 strings) Translation: payroll-14.0/payroll-14.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll_account/es_AR/
Currently translated at 100.0% (24 of 24 strings) Translation: payroll-14.0/payroll-14.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-14-0/payroll-14-0-payroll_account/es/
…cumentation [14.0] [IMP] payroll: improve salary rules views and documentation [14.0] [IMP] payroll: improve salary rules and categories views [14.0] [IMP] payroll: improve salary rules views and documentation [14.0] [IMP] payroll: improve salary rules views and documentation [IMP] payroll: fix repeated words [14.0] [IMP] payroll: fix typos
[14.0] [IMP] payroll: change manifest category [14.0] [IMP] payroll: add migration for new payslip and payslips objects [14.0] [IMP] payroll: add migration for new payslip and payslips objects [14.0] [IMP] payroll: add migration for new payslip and payslips objects
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: payroll-16.0/payroll-16.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-16-0/payroll-16-0-payroll_account/
Currently translated at 100.0% (21 of 21 strings) Translation: payroll-16.0/payroll-16.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-16-0/payroll-16-0-payroll_account/fa/
Currently translated at 100.0% (22 of 22 strings) Translation: payroll-18.0/payroll-18.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-18-0/payroll-18-0-payroll_account/es_VE/
Currently translated at 100.0% (22 of 22 strings) Translation: payroll-18.0/payroll-18.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-18-0/payroll-18-0-payroll_account/es/
Currently translated at 100.0% (22 of 22 strings) Translation: payroll-18.0/payroll-18.0-payroll_account Translate-URL: https://translation.odoo-community.org/projects/payroll-18-0/payroll-18-0-payroll_account/tr/
edescalona
force-pushed
the
17.0-mig-payroll_account
branch
from
7ed7f43 to
45cfdab
Compare
rrebollo
reviewed
Sep 20, 2025
rrebollo
left a comment
rrebollo
left a comment
There was a problem hiding this comment.
Thank you for your contribution. This module contains deep functional knowledge, so it’s better to wait for more highly ranked reviews, but I can already see good work here. Feel free to address my comment on migrations scripts.
[IMP] payroll_account: Remove folder migrations
edescalona
force-pushed
the
17.0-mig-payroll_account
branch
from
45cfdab to
146e01e
Compare
Member
|
@edescalona #189 was not a viable PR. |
Member
|
PS: the 18.0 migration was based on 16.0 of course, so you might want to look at the additional commits done for 18.0 and consider cherry-picking them. |
Author
|
Hi @dreispt , if I migrated from 18.0, all that's missing is a review of this PR, both functional and code-wise. Thanks for your feedback. |
nimarosa
approved these changes
Sep 22, 2025
Contributor
|
Just reviewed it via runboat. It looks like it works okay. /ocabot merge nobump |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at e986f76. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BinhexTeam
Reasons why the PR was created:
Hi @dreispt @nimarosa , if you could review the PR or clarify the issue with the merged module in case there's a reason I'm not aware of, thank you.