[ADD]pms: change related by compute in checkin name#370
Merged
OCA-git-bot merged 2 commits intoOCA:16.0from Mar 21, 2026
Merged
[ADD]pms: change related by compute in checkin name#370OCA-git-bot merged 2 commits intoOCA:16.0from
OCA-git-bot merged 2 commits intoOCA:16.0from
Conversation
jesusVMayor
force-pushed
the
16.0-checkin_partner_name_compute
branch
from
4877f68 to
9a916b5
Compare
Member
Author
|
/ocabot merge minor |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at 9441baf. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how the
namefield is managed for thePmsCheckinPartnermodel. Instead of being a related field,nameis now a computed and stored field, allowing for more flexible and accurate name handling, especially whenpartner_idis not set. The computation logic has also been expanded to derive the name from first and last name fields when necessary.Field definition and computation improvements:
namefield inPmsCheckinPartnerfrom a related field to a computed and stored field, using the_compute_namemethod for its value._compute_namemethod to depend onpartner_id,firstname,lastname, andlastname2, and to compute the name from these fields ifpartner_idis not set.ATENTION: Need review pms_l10n_es & pms_fastapi_contact_lastname2 to take account lastname2 in the compute