[17.0][ADD] pos_user_restrict_stripe_bypass_user: New module pos_user_restrict_stripe_bypass_user #1324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peluko00
force-pushed
the
17.0-add-pos_user_restrict_stripe_bypass_user
branch
10 times, most recently
from
1efc4f6 to
9bc56f9
Compare
Author
|
Hi @eLBati, can you review please? |
Author
|
Sorry for ping here @legalsylvain, it's ready for merge? |
Author
|
It's ready for merge @legalsylvain ? |
…_restrict_stripe_bypass_user
peluko00
force-pushed
the
17.0-add-pos_user_restrict_stripe_bypass_user
branch
from
9bc56f9 to
b995ee2
Compare
Author
|
Sorry for ping here @ivantodorovich, seems it's ready for merge |
ivantodorovich
approved these changes
Jan 13, 2026
ivantodorovich
left a comment
ivantodorovich
left a comment
There was a problem hiding this comment.
Thanks!
LGTM, just one small comment about the context key value, that's supposed to be a boolean AFAICS.
It still works like this, cause the string "bypass_pos_user" is a truthy value, but for clarity I suggest being more explicit
Pre-approving
| if self.env.user.has_group( | ||
| "pos_user_restriction.group_assigned_points_of_sale_user" | ||
| ): | ||
| self = self.with_context(bypass_pos_user="bypass_pos_user") |
There was a problem hiding this comment.
Suggested change
| self = self.with_context(bypass_pos_user="bypass_pos_user") | |
| self = self.with_context(bypass_pos_user=True) |
(other cases too)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module allows you to use stripe in POS with the group user assigned POS only.
cc https://github.com/APSL 167743
@miquelalzanillas @lbarry-apsl @mpascuall @ppyczko @javierobcn @BernatObrador please review