[FIX]pos_partner_birthdate: fixed the issue of if we have a lot of customers and we search a customer using the birthdate with the button search more, result not found.

[parvezqureshi]

#1328

[OCA-git-bot]

Hi @ecino,
some modules you are maintaining are being modified, check this out!

[cvinh]

cc @vehi-invitu

[cvinh]

thanks for the PR, we tested here in french at GMT-10 and with several format input (ddmmyyyy or dd/mm/yyyy), it doesn't seem to work as expected
Can you do it language and format date proof ? At least ddmmyyyy and dd/mm/yyyy for french and mmyyyyyy or mm/dd/yyyy for english
Please be aware of timezone because if we are at another timezone than UTC, the date might move +/-1 day

As example @etobella did it like this

pos/pos_partner_birthdate/static/src/js/PosDB.esm.js

Line 9 in dfa4435

var result = super._partner_search_string(partner);

and it works well with the classical search

[cvinh]

works as expected

[vehi-invitu]

I tested it and it works as expected.

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[etobella]

Small, suggestion, why don't you ask Odoo to add a hook in order to modify the domain filter? this way, you don't need to have this big change.

I made other PRs asking for hooks and they accepted it without an issue:
odoo/odoo#150914

[cvinh]

Small, suggestion, why don't you ask Odoo to add a hook in order to modify the domain filter? this way, you don't need to have this big change.

I made other PRs asking for hooks and they accepted it without an issue: odoo/odoo#150914

odoo/odoo#202641

[cvinh]

Maybe we can merge this one and wait for odoo/odoo#202641 to improve it
Otherwise, we do a PR to OCB and improve it now
@etobella WDYT ?

[cvinh]

@legalsylvain WDYT on that one please ?

[cvinh]

please @parvezqureshi can you rebase because of runboat ?

[parvezqureshi]

please @parvezqureshi can you rebase because of runboat ?

Rebased

[cvinh]

Small, suggestion, why don't you ask Odoo to add a hook in order to modify the domain filter? this way, you don't need to have this big change.
I made other PRs asking for hooks and they accepted it without an issue: odoo/odoo#150914

odoo/odoo#202641

PR has been rejected by Odoo and I proposed to do a PR to OCB... In that case, this fix will only work with OCB... or we can merge as it is... and improve it in next version
PSC wdyt ?

[cvinh]

Odoo answered this part has been changed in further versions, so we can merge this and then improve in next versions
@legalsylvain

[ivantodorovich]

I wouldn't have a problem merging like this, but please add some comments mentioning we're fully overwriting the core method and why.

Add comments before and after the modified lines to make it easier for devs working in future migrations to identify the actual patch.

Alternatively, there's a way to do this without a complete overwrite. It's not as clean as if Odoo had a hook method, but it works just fine: you can temporarily monkey-patch the this.orm.silent.call method with a method that injects your new domain leaves. Call super in a try..finally block, reverting the monkey patch after its called.

[ivs-cetmix]

Hey @parvezqureshi than you for your contribution! Could you please check the comments and resolve them?