Skip to content

Conversation

@kamladodiyaserpentcs
Copy link

…he POS (Point of Sale) system by implementing barcode scanning functionality for product search.

@kamladodiyaserpentcs kamladodiyaserpentcs force-pushed the 17.0-ADD-pos_product_search_gs1 branch from a75ec9e to e43038a Compare March 19, 2025 08:59
@kamladodiyaserpentcs
Copy link
Author

@cvinh,
Can you please review it?

@@ -0,0 +1 @@
This module enhances the POS (Point of Sale) system by implementing barcode scanning functionality for product search. No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add USAGE
In the point of sale product list screen, clic in the search bar and scan the GS1 code

@kamladodiyaserpentcs kamladodiyaserpentcs force-pushed the 17.0-ADD-pos_product_search_gs1 branch from 0e45015 to eac1d8f Compare March 28, 2025 06:46
Copy link

@vehi-invitu vehi-invitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamladodiyaserpentcs, I tested the module with Runboat using some of our medical product information (serial number, lot, cip). When I search for the product by scanning its GS1 code, the POS screen turns white.

Capture d’écran du 2025-03-31 11-57-06

I tested these 2 cases : (add in the order and search the product)
1/ The product with the CIP, lot number and expiration date
2/ The product with the CIP, serial et lot numbers and expiration date

Capture.video.du.2025-03-31.12-27-16.webm

@kamladodiyaserpentcs kamladodiyaserpentcs force-pushed the 17.0-ADD-pos_product_search_gs1 branch from eac1d8f to 3ad4ffa Compare April 15, 2025 06:00
@kamladodiyaserpentcs
Copy link
Author

@cvinh
Can you please review it?

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 31, 2025
@cvinh
Copy link
Contributor

cvinh commented Sep 18, 2025

@cvinh Can you please review it?

we can't test on runboat, @kamladodiyaserpentcs can you rebase again please ?
@vehi-invitu if runboat is till stuck, please review it in local

…he POS (Point of Sale) system by implementing barcode scanning functionality for product search.
…he POS (Point of Sale) system by implementing barcode scanning functionality for product search.
@kamladodiyaserpentcs kamladodiyaserpentcs force-pushed the 17.0-ADD-pos_product_search_gs1 branch from 3ad4ffa to bd64b72 Compare September 18, 2025 10:11
@kamladodiyaserpentcs
Copy link
Author

@cvinh , @vehi-invitu

I have rebased the branch on top of the latest 17.0.
I also tested locally with GS1 barcodes (with/without lot and expiry), and it works fine.
Please review again?

Thanks!

Copy link

@vehi-invitu vehi-invitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Runboat, LGTM.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants