[FIX] pos_meal_voucher: remove unoverloadable function.#565
Merged
OCA-git-bot merged 1 commit intoOCA:12.0from May 13, 2021
Merged
Conversation
quentinDupont
approved these changes
Nov 16, 2020
Contributor
Author
|
/ocabot merge patch |
Contributor
|
On my way to merge this fine PR! |
OCA-git-bot
added a commit
that referenced
this pull request
May 13, 2021
Contributor
|
It looks like something changed on |
Contributor
|
Congratulations, your PR was merged at 6f25d22. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the function that the PR remove is not overloable with that way. More precisely it fails if there is a confirm action inside due to the poor design of odoo Point of sale.
the same patch should be applied in
pos_tare.Step to reproduce :
CC : @grap : #/board/144/card/1099 @quentinDupont
CC : @Fkawala