Skip to content

[13.0][FIX]pos_order_mgmt: Fix bug when restore payment lines from a done o…#733

Merged
OCA-git-bot merged 1 commit into
OCA:13.0from
Comunitea:13.0_fix-reprint
Feb 15, 2022
Merged

[13.0][FIX]pos_order_mgmt: Fix bug when restore payment lines from a done o…#733
OCA-git-bot merged 1 commit into
OCA:13.0from
Comunitea:13.0_fix-reprint

Conversation

@javierjcf

Copy link
Copy Markdown

…rder. Fixes #732

@legalsylvain

Copy link
Copy Markdown
Contributor

Thanks @javierjcf for the patch !

@dalonsod could you take a look on that PR, as you made the port of the module to 13 ? (#584)

regards.

@dalonsod

dalonsod commented Dec 8, 2021

Copy link
Copy Markdown

Hello @javierjcf , thanks for the contribution!

Locally tested, works as expected. Please squash commits and execute pre-commit stuff.

@javierjcf

Copy link
Copy Markdown
Author

Hi @dalonsod
I did squash and the pre-commit

@chienandalu

Copy link
Copy Markdown
Member

Are you sure? It's still failing

…rder. Fixes OCA#732

[FIX]pos_order_mgmt: Fix lint error

Correction quotes
@dalonsod

Copy link
Copy Markdown

Hello @javierjcf if you install pre-commit python library and execute pre-commit run -a that command will do that work

@javierjcf

Copy link
Copy Markdown
Author

Thanks @dalonsod , it's well done right now i think

My problem was not commiting changes that pre-commit did

@chienandalu chienandalu changed the title [FIX]pos_order_mgmt: Fix bug when restore payment lines from a done o… [13.0][FIX]pos_order_mgmt: Fix bug when restore payment lines from a done o… Feb 15, 2022
@chienandalu

Copy link
Copy Markdown
Member

/ocabot merge minor

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-733-by-chienandalu-bump-minor, awaiting test results.

@chienandalu

Copy link
Copy Markdown
Member

Thanks @javierjcf :)

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 85133da into OCA:13.0 Feb 15, 2022
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at fefe91b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants