Skip to content

[14.0][FIX] pos_product_multi_barcode: enable feature to search for p…#801

Merged
OCA-git-bot merged 1 commit into
OCA:14.0from
ilyasProgrammer:14.0-pos_product_multi_barcode-search_bar-fix
Jun 24, 2022
Merged

[14.0][FIX] pos_product_multi_barcode: enable feature to search for p…#801
OCA-git-bot merged 1 commit into
OCA:14.0from
ilyasProgrammer:14.0-pos_product_multi_barcode-search_bar-fix

Conversation

@ilyasProgrammer
Copy link
Copy Markdown
Member

@ilyasProgrammer ilyasProgrammer commented Jun 23, 2022

…roducts by multiple barcodes in search bar of POS.

Fix of the issue mentioned here #768

legalsylvain
legalsylvain requested changes Jun 23, 2022
View reviewed changes
Comment thread pos_product_multi_barcode/static/src/js/db.js Outdated
@ilyasProgrammer ilyasProgrammer force-pushed the 14.0-pos_product_multi_barcode-search_bar-fix branch from 9ce1976 to dc593e6 Compare June 24, 2022 05:55
francesco-ooops
francesco-ooops approved these changes Jun 24, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok!

@ilyasProgrammer I don't think there's the need to update version, and if you can squash commits I think it could be ready for merge, thanks!

@ilyasProgrammer
[14.0][FIX] pos_product_multi_barcode: enable feature to search for p…
5a10a0d 
…roducts by multiple barcodes in search bar of POS.
@ilyasProgrammer ilyasProgrammer force-pushed the 14.0-pos_product_multi_barcode-search_bar-fix branch from dc593e6 to 5a10a0d Compare June 24, 2022 08:33
@francesco-ooops
Copy link
Copy Markdown
Contributor

francesco-ooops commented Jun 24, 2022

@legalsylvain think it's good for merge?

@legalsylvain
Copy link
Copy Markdown
Contributor

legalsylvain commented Jun 24, 2022

@ilyasProgrammer I don't think there's the need to update version, and if you can squash commits I think it could be ready for merge, thanks!

Indeed bumping version is done by people who merge with ocabot command.

legalsylvain
legalsylvain approved these changes Jun 24, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes !

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jun 24, 2022

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-801-by-legalsylvain-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 22823c3 into OCA:14.0 Jun 24, 2022
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jun 24, 2022

Congratulations, your PR was merged at c834861. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legalsylvain legalsylvain legalsylvain approved these changes

+1 more reviewer

@francesco-ooops francesco-ooops francesco-ooops approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ilyasProgrammer @francesco-ooops @legalsylvain @OCA-git-bot