[16.0][ADD] new simple module for bulk product

[quentinDupont]

In a context of organic groceries selling lot of bulk products, we need to quickly identify them so this module adds this simple computed (and inverse) field

[MDgrap]

Tested with runboat, works as intended

[legalsylvain]

hi. thanks for your contribution !
some remarks inline. a blocking one regarding onchange / computed.

Otherwise, LGTM.
thanks !

[legalsylvain]

Suggested change

	is_bulk = fields.Boolean()
	# Onchange Section
	@api.onchange("uom_id")
	def onchange_uom_id(self):
	self.is_bulk = (
	True
	if self.uom_id.category_id.measure_type in ["weight", "volume"]
	else False
	)
	is_bulk = fields.Boolean(compute="_compute_is_bulk", readonly=False)
	@api.depends("uom_id.category_id.measure_type")
	def _compute_is_bulk(self):
	for product in self:
	product.is_bulk = product.uom_id.category_id.measure_type in ["weight", "volume"]

Better to replace by a computed function (readonly = False). As a result, the code will be raised in more moment. for exemple,

• if we import product massively, computation will be done. (it is not the case I think if it's onchange).
• when installing the module, the computation will be done for all existing product.

WDYT ?

Note : maybe it is requiring an SQL script to initialize more quickly the database...)

[quentinDupont]

I chose onchange by simplicity because we also want to handle few cases where product is bulk but is not marked for sale by weight : e.g cookies sold in bulk in a jar, the price being by unit.

But indeed, maybe we can go "compute" and add an inverse function

[quentinDupont]

Weird, my PR description talks about compute and inverse function, maybe that was my first idea ^^

[legalsylvain]

Suggested change

	# Onchange Section
	@api.onchange("uom_id")
	def onchange_uom_id(self):
	ProductProduct.onchange_uom_id(self)

[legalsylvain]

Suggested change

self.product1.onchange_uom_id()

[legalsylvain]

I think that an helper could be great for that field. somethink like

help="Check this box if this product is sold without any manufactured packaging. It is usually the case for product whose unit of measure is a unit of weight or volume, but it can be also the case for products priced per unit but sold in bulk (such as cookies, bread, etc.)"

[quentinDupont]

ok you had the same example :-p

[legalsylvain]

I think it will work the same, and be more synthetic.

[legalsylvain]

Suggested change

	def _inverse_is_bulk(self):
	pass

[legalsylvain]

Suggested change

	inverse="_inverse_is_bulk",
	readonly=False,

[legalsylvain]

thanks !

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[legalsylvain]

/ocabot merge nobump

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-2259-by-legalsylvain-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at f698b81. Thanks a lot for contributing to OCA. ❤️