[13.0][ADD]product_attribute_value_menu#997
Conversation
JordiMForgeFlow
left a comment
There was a problem hiding this comment.
Simple but really useful! Nice one @GuillemCForgeFlow 👍🏼
|
@GuillemCForgeFlow please add _menu as suffix. Just like https://github.com/OCA/account-financial-tools/tree/14.0/account_asset_management_menu |
AaronHForgeFlow
left a comment
There was a problem hiding this comment.
Thanks @GuillemCForgeFlow
Is it possible to remove the dependency on product_attribute_archive?
I have added the field active on the tree view. For this reason it's added on the dependencies, but I could remove it from both sides. As you prefer. |
|
@GuillemCForgeFlow product_attribute_archive should be the one depending on this one, not the other way around, I think. |
Yes, then you can inherit the view on the product_attribute_archive module in order to add the active fields. Sorry for the extra work, but I think this will improve extensibility a lot. |
58044a1 to
8a40f3d
Compare
8a40f3d to
883ccf3
Compare
|
@AaronHForgeFlow @JordiBForgeFlow |
AaronHForgeFlow
left a comment
There was a problem hiding this comment.
👍 great! -thanks for attending all the suggestions
883ccf3 to
925c886
Compare
|
This PR has the |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 637f8a2. Thanks a lot for contributing to OCA. ❤️ |
This new module it's based on this #984 which was proposing an improvement to the product_attribute_archive module. Instead, i'ts now a separate module which adds a Attribute Values menu item and tree view.
@ForgeFlow @JordiMForgeFlow @AaronHForgeFlow