[17.0][MIG] project_task_name_with_id: Migration to 17.0 #1472

lbarry-apsl · 2025-04-10T14:59:53Z

Module migrated to version 17.0

cc https://github.com/APSL 7983
@miquelalzanillas @javierobcn @mpascuall @BernatObrador @ppyczko @peluko00 please review

#1191

Currently translated at 100.0% (1 of 1 strings) Translation: project-16.0/project-16.0-project_task_name_with_id Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_name_with_id/it/

mpascuall

LGTM!

peluko00

LGTM!

BernatObrador

This isn't working correctly.

Example from version 16:

Current behavior:

The ID is no longer inside brackets [ ], now the name is inside instead. And the name it's between ' '. Something seems to be wrong with this.

Also, when you create a new task, it ends up like this:

lbarry-apsl · 2025-04-25T10:53:24Z

This isn't working correctly.

Example from version 16:

Current behavior:

The ID is no longer inside brackets [ ], now the name is inside instead. And the name it's between ' '. Something seems to be wrong with this.

Also, when you create a new task, it ends up like this:

Done @BernatObrador !!

BernatObrador

LGTM!

BernatObrador · 2025-04-29T06:18:58Z

project_task_name_with_id/tests/test_project_task_id.py

+
+
+class TestProjectTaskID(TransactionCase):
+    def setUp(self):


Just a minor comment, test should be using @classsmethod

Suggested change

def setUp(self):

@classmethod

def setUpClass(cls):

yostashiro · 2025-04-29T09:19:54Z

project_task_name_with_id/models/project_task.py

+            if hasattr(task, "key") and task.key:
+                parts.append(task.key)


Wasn't sure about the validity of this part. Shouldn't we add super()._compute_display_name() at the beginning to adjust the updated display_name, instead?

@yostashiro this is to make the module compatible with project_key without depending on it. Or do you think it's not necessary?

@lbarry-apsl IMO, we shouldn't add special logic just to be "compatible" with another module. Would there be any issue if we simply did the following?

@api.depends("name") def _compute_display_name(self): super()._compute_display_name() for task in self: task.display_name = f"[{task.id}] {task.display_name}"

There wasn't an error, just that the task.key wasn't displayed in the ticket name added by the project_key module.

@yostashiro if it's not a problem, I can leave it as you've told me.

@lbarry-apsl IMO, we shouldn't add special logic just to be "compatible" with another module. Would there be any issue if we simply did the following?

@api.depends("name") def _compute_display_name(self): super()._compute_display_name() for task in self: task.display_name = f"[{task.id}] {task.display_name}"

@yostashiro I have done the tests with what you propose here, but the result with the project_key is this and it is not correct [5] 5['OD-1', 'Energy Certificate']

I have done the tests with what you propose here, but the result with the project_key is this and it is not correct [5] 5['OD-1', 'Energy Certificate'].

@lbarry-apsl I think that's because how project_key doesn't use super() in _compute_display_name(). Likewise, the current implementation of this module may break the presentation of the display name if there is another module which manipulates with the field.

Okay, I understand. I mentioned in this PR #1503 that it adds the super() function without modifying the logic.

@lbarry-apsl @yostashiro I created PRs to avoid complete overidding.
#1502
#1503

yostashiro · 2025-04-29T09:20:07Z

project_task_name_with_id/__manifest__.py

+{
+    "name": "Project Task Name with ID",
+    "category": "Project",
+    "version": "17.0.1.0.1",


Suggested change

"version": "17.0.1.0.1",

"version": "17.0.1.0.0",

lbarry-apsl · 2025-05-13T09:59:49Z

Hi @pedrobaeza , can you check this migration?

pedrobaeza · 2025-05-13T10:07:48Z

/ocabot migration project_task_name_with_id
/ocabot merge nobump

OCA-git-bot · 2025-05-13T10:07:55Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1472-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2025-05-13T10:14:52Z

Congratulations, your PR was merged at 1c65bca. Thanks a lot for contributing to OCA. ❤️

AungKoKoLin1997 and others added 8 commits April 10, 2025 16:51

[ADD] project_task_name_with_id

0de63ce

[UPD] Update project_task_name_with_id.pot

c65364c

[BOT] post-merge updates

7c876e7

Added translation using Weblate (Italian)

0686b56

Translated using Weblate (Italian)

84f777f

Currently translated at 100.0% (1 of 1 strings) Translation: project-16.0/project-16.0-project_task_name_with_id Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_name_with_id/it/

[16.0][IMP] project_task_name_with_id: improve searching

4d5c6ef

[BOT] post-merge updates

e26dd67

[IMP] project_task_name_with_id: pre-commit auto fixes

7161eb5

mpascuall approved these changes Apr 11, 2025

View reviewed changes

peluko00 approved these changes Apr 11, 2025

View reviewed changes

OCA-git-bot added the approved label Apr 11, 2025

BernatObrador suggested changes Apr 11, 2025

View reviewed changes

OCA-git-bot removed the approved label Apr 11, 2025

lbarry-apsl force-pushed the 17.0-mig-project_task_name_with_id branch from 10ed5ed to ab2103e Compare April 14, 2025 09:09

lbarry-apsl force-pushed the 17.0-mig-project_task_name_with_id branch from ab2103e to 3387508 Compare April 25, 2025 10:50

lbarry-apsl requested a review from BernatObrador April 25, 2025 10:54

BernatObrador approved these changes Apr 29, 2025

View reviewed changes

OCA-git-bot added the approved label Apr 29, 2025

BernatObrador reviewed Apr 29, 2025

View reviewed changes

yostashiro reviewed Apr 29, 2025

View reviewed changes

[MIG] project_task_name_with_id: Migration to 17.0

e885105

lbarry-apsl force-pushed the 17.0-mig-project_task_name_with_id branch from 3387508 to e885105 Compare May 5, 2025 06:30

OCA-git-bot added this to the 17.0 milestone May 13, 2025

OCA-git-bot added the bot is merging ⏳ label May 13, 2025

OCA-git-bot mentioned this pull request May 13, 2025

Migration to version 17.0 #1191

Open

37 tasks

OCA-git-bot merged commit ae5f3de into OCA:17.0 May 13, 2025
5 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels May 13, 2025

Uh oh!

[17.0][MIG] project_task_name_with_id: Migration to 17.0 #1472

[17.0][MIG] project_task_name_with_id: Migration to 17.0 #1472

Uh oh!

Conversation

lbarry-apsl commented Apr 10, 2025

Uh oh!

mpascuall left a comment

Choose a reason for hiding this comment

Uh oh!

peluko00 left a comment

Choose a reason for hiding this comment

Uh oh!

BernatObrador left a comment

Choose a reason for hiding this comment

Uh oh!

lbarry-apsl commented Apr 25, 2025

Uh oh!

BernatObrador left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AungKoKoLin1997 May 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lbarry-apsl commented May 13, 2025

Uh oh!

pedrobaeza commented May 13, 2025

Uh oh!

OCA-git-bot commented May 13, 2025

Uh oh!

Uh oh!

OCA-git-bot commented May 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

AungKoKoLin1997 May 14, 2025 •

edited

Loading