Skip to content

Conversation

@mathben
Copy link

@mathben mathben commented Sep 17, 2025

Migrate from odoo 12
project_budget

@mathben mathben changed the title 18.0 mig project budget [18.0][MIG] project_budget Sep 17, 2025
@mathben
Copy link
Author

mathben commented Sep 17, 2025

Build failed, because depend on OCA/account-budgeting#79

@rousseldenis
Copy link

/ocabot migration project_budget

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Oct 12, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 12, 2025
39 tasks
@mathben mathben force-pushed the 18.0-mig-project_budget branch 3 times, most recently from 2472bc9 to a629ded Compare October 15, 2025 04:10
@mathben
Copy link
Author

mathben commented Oct 15, 2025

I format code on last force-pushed commit

@mathben mathben force-pushed the 18.0-mig-project_budget branch from a629ded to 0396a4d Compare December 6, 2025 03:00
@mathben
Copy link
Author

mathben commented Dec 6, 2025

@rousseldenis
This pull request is fixed and all check pass after a rebase.
Thanks for your review!

Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something looks strange in the setup directory. This setup directory is similar to what we had until Odoo 16.0, but since 17.0 it's not supposed to be like that.

in version 18.0, There is still a setup directory, but it's only a global setup for the repo, see for instance: https://github.com/OCA/dms/tree/18.0/setup/_metapackage and each module don't touch that setup directory but only bring a pyproject.toml, see for instance: https://github.com/OCA/dms/blob/18.0/dms/pyproject.toml

Are you sure you use the version 18.0 pre-commit setup for this pull request? You should fix this.

@mathben mathben force-pushed the 18.0-mig-project_budget branch from 761bbc8 to e94448e Compare December 9, 2025 02:21
@mathben
Copy link
Author

mathben commented Dec 9, 2025

Thanks for your review @rvalyi
I did the change manually, but do we have automated command to do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants