Skip to content

Conversation

@Tisho99
Copy link
Contributor

@Tisho99 Tisho99 commented Dec 19, 2025

When a stock move linked to a task is returned, the generated analytic line currently keeps the same amount as the original move’s analytic line.

This PR updates the behavior so that the amount is created with the opposite sign, correctly reflecting the return.

@OCA-git-bot
Copy link
Contributor

Hi @victoralmau,
some modules you are maintaining are being modified, check this out!

Copy link

@Jaimermaccione Jaimermaccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tisho99 LGTM. Reviewed on local environment.

Tests performed:

  1. Material consumption
  2. Partial and full returns
  3. Mixed products with returns

All scenarios behaved as expected: correct signs, totals, pricing, and full analytic/stock traceability.

Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be coherent

@Tisho99 Tisho99 marked this pull request as ready for review December 22, 2025 16:52
@pedrobaeza pedrobaeza added this to the 16.0 milestone Dec 22, 2025
@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1631-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0624865 into OCA:16.0 Dec 22, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c85689e. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza
Copy link
Member

Please cherry-pick it to upper versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants