[18.0][FIX] project_sequence: remove the inherited kanban view#1683
Conversation
d55d0a2 to
21b8d43
Compare
|
Hi @anddago78, @yajo, |
alexey-pelykh
left a comment
There was a problem hiding this comment.
The kanban view override was likely conflicting with 18.0 base template changes. Clean removal, CI passes. LGTM.
alexey-pelykh
left a comment
There was a problem hiding this comment.
Review: project_sequence kanban view removal
Verdict: APPROVE
This is a clean and correct removal of a redundant inherited kanban view.
Analysis
The removed project_sequence_kanban_view was inheriting project.view_project_kanban and performing three xpath operations:
- Adding the
namefield afterdisplay_name - Hiding the original
display_namespan (invisible=1) - Adding a replacement span rendering the same
display_name.value
This was effectively a no-op because the module already overrides _compute_display_name to include the sequence code in the display name (e.g. "23-00011 - Project Name"). The core kanban view already renders display_name, so the inherited view was replacing the display_name span with... the same display_name value.
In Odoo 18.0, the core kanban template structure likely changed, making these xpath selectors fragile or conflicting. Removing this unnecessary override is the right fix.
Checklist
- Correctness: No other files reference the
project_sequence_kanban_viewXML ID - Manifest: No changes needed --
views/project_project.xmldata file is still loaded - Tests: Existing tests cover model behavior (
display_name,sequence_code,name_search) and are unaffected - i18n: No translatable strings in the removed block
- Security: No concerns
- Performance: Slightly improved (one fewer view inheritance layer)
- CI: runboat/build passing
Review posted via CorporateHub OCA review campaign
|
This PR has the |
2 similar comments
|
This PR has the |
|
This PR has the |
yajo
left a comment
There was a problem hiding this comment.
Thanks everyone.
/ocabot merge minor
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 4cb63a7. Thanks a lot for contributing to OCA. ❤️ |
Remove the inherited kanban view because it already exists in core Odoo.