Skip to content

[18.0][FIX] project_sequence: remove the inherited kanban view#1683

Merged
OCA-git-bot merged 1 commit intoOCA:18.0from
ecosoft-odoo:18.0-project_sequence_delete_view_kanban
Mar 4, 2026
Merged

[18.0][FIX] project_sequence: remove the inherited kanban view#1683
OCA-git-bot merged 1 commit intoOCA:18.0from
ecosoft-odoo:18.0-project_sequence_delete_view_kanban

Conversation

@Saran440
Copy link
Member

Remove the inherited kanban view because it already exists in core Odoo.

@Saran440 Saran440 force-pushed the 18.0-project_sequence_delete_view_kanban branch from d55d0a2 to 21b8d43 Compare February 27, 2026 03:22
@Saran440 Saran440 marked this pull request as ready for review February 27, 2026 03:23
@OCA-git-bot
Copy link
Contributor

Hi @anddago78, @yajo,
some modules you are maintaining are being modified, check this out!

Copy link
Contributor

@alexey-pelykh alexey-pelykh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kanban view override was likely conflicting with 18.0 base template changes. Clean removal, CI passes. LGTM.

Copy link
Member

@CristianoMafraJunior CristianoMafraJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alexey-pelykh alexey-pelykh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: project_sequence kanban view removal

Verdict: APPROVE

This is a clean and correct removal of a redundant inherited kanban view.

Analysis

The removed project_sequence_kanban_view was inheriting project.view_project_kanban and performing three xpath operations:

  1. Adding the name field after display_name
  2. Hiding the original display_name span (invisible=1)
  3. Adding a replacement span rendering the same display_name.value

This was effectively a no-op because the module already overrides _compute_display_name to include the sequence code in the display name (e.g. "23-00011 - Project Name"). The core kanban view already renders display_name, so the inherited view was replacing the display_name span with... the same display_name value.

In Odoo 18.0, the core kanban template structure likely changed, making these xpath selectors fragile or conflicting. Removing this unnecessary override is the right fix.

Checklist

  • Correctness: No other files reference the project_sequence_kanban_view XML ID
  • Manifest: No changes needed -- views/project_project.xml data file is still loaded
  • Tests: Existing tests cover model behavior (display_name, sequence_code, name_search) and are unaffected
  • i18n: No translatable strings in the removed block
  • Security: No concerns
  • Performance: Slightly improved (one fewer view inheritance layer)
  • CI: runboat/build passing

Review posted via CorporateHub OCA review campaign

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

2 similar comments
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everyone.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1683-by-yajo-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit eaffe53 into OCA:18.0 Mar 4, 2026
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4cb63a7. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants