[19.0][FIX] project_task_description_template: HTML fields wrap text in <p>#1738
Closed
dnplkndll wants to merge 1 commit into
Closed
[19.0][FIX] project_task_description_template: HTML fields wrap text in <p>#1738dnplkndll wants to merge 1 commit into
dnplkndll wants to merge 1 commit into
Conversation
…apping Odoo 19.0 Html fields wrap bare text in <p> rather than <span>, so the onchange that appends a template's description now yields <p>…</p>. Update the two test expectations accordingly; the module behaviour is unchanged.
OCA-git-bot
added
series:19.0
mod:project_task_description_template
Author
|
@NICO-SOLUTIONS @alan196 @Shide just looking to get the CI running. will investigate more if there is a better option. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestDescriptionTemplatefails on 19.0: the two assertions expect the templatetext wrapped in
<span>, but Odoo 19.0'sHtmlfield now wraps bare text in<p>. So_onchange_description_template_idproduces<p>- Sample Description</p>.The module behaviour is correct — only the test's hard-coded expectations were
stale. This updates them to
<p>, turning the module's tests green again on the19.0 branch.