Conversation
There was a problem hiding this comment.
For these cases, isn't better to leave the translation blank?
Member
Author
There was a problem hiding this comment.
Not sure; probably this takes them out of unstranslated lists.
|
In porting to 8.0. We should be using the new api. |
Member
Author
|
I agree on using the new API, but the priority is to get modules installable on v8, so we can work on database migrations. So, I would prefer to work on that (and on test coverage) at a later stage. |
Member
|
I also agree with Daniel. First: get v8 compatibility with minimal changes. Second: refactor with new API. Regards. |
Member
|
On 07/22/2014 04:15 PM, Pedro M. Baeza wrote:
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.