Skip to content

[14.0][FIX] It seems that sometimes jobs doesn't have a job_method and the __repr__ failed #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OCA-git-bot merged 1 commit into from
Jun 30, 2022
Merged

[14.0][FIX] It seems that sometimes jobs doesn't have a job_method and the __repr__ failed #440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion queue_job/delay.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,8 +492,11 @@ def _tail(self):
return [self]

def __repr__(self):
job_method = ""
Copy link
Copy Markdown
Contributor

@rousseldenis rousseldenis Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be something more user friendly than a void string ?

Copy link
Copy Markdown
Contributor Author

@acsonefho acsonefho Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That happens when the current object is related to nothing. So what do you propose? :)

if self._job_method:
job_method = self._job_method.__name__
return "Delayable({}.{}({}, {}))".format(
self.recordset, self._job_method.__name__, self._job_args, self._job_kwargs
self.recordset, job_method, self._job_args, self._job_kwargs
)

def __del__(self):
Expand Down