Skip to content

[17.0] [FIX] queue_job: fix exception msg handling#825

Merged
OCA-git-bot merged 1 commit intoOCA:17.0from
acsone:17.0-fix_exception_name_to_args0-bwi
Sep 18, 2025
Merged

[17.0] [FIX] queue_job: fix exception msg handling#825
OCA-git-bot merged 1 commit intoOCA:17.0from
acsone:17.0-fix_exception_name_to_args0-bwi

Conversation

@ThomasBinsfeld
Copy link
Copy Markdown
Contributor

@ThomasBinsfeld ThomasBinsfeld commented Sep 16, 2025

Forward port of #824

18.0 PR : #826

Use args[0] instead of name to get the exception message as the name attribute is deprecated

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

Copy link
Copy Markdown
Member

@FrancoMaxime FrancoMaxime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@AnizR AnizR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@amh-mw amh-mw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage?

@ThomasBinsfeld
Copy link
Copy Markdown
Contributor Author

The modified file doesn't seem covered at all, we won't write its coverage in this PR. I suggest to merge as it. ping @guewen

'name' attributes for odoo's exception has been deprecated and produces a warning message. This commit fixes the behavior
@ThomasBinsfeld ThomasBinsfeld force-pushed the 17.0-fix_exception_name_to_args0-bwi branch from 2b1e382 to eb3501d Compare September 17, 2025 08:20
@guewen
Copy link
Copy Markdown
Member

guewen commented Sep 18, 2025

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-825-by-guewen-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 49e2cb5 into OCA:17.0 Sep 18, 2025
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at c9e92aa. Thanks a lot for contributing to OCA. ❤️

@sbidoul sbidoul deleted the 17.0-fix_exception_name_to_args0-bwi branch January 4, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants