[18.0][FIX] Adapt queue_job_profiler to job aquisition refactor#941
[18.0][FIX] Adapt queue_job_profiler to job aquisition refactor#941TDu wants to merge 2 commits into
Conversation
|
Hi @simahawk, |
amh-mw
left a comment
There was a problem hiding this comment.
Code review only, LGTM. Bonus points still available for a unit test that would have noticed the method signature change.
|
@TDu can you try to add the test? ? |
Broken by job acquisition refactoring OCA#941
8fc1700 to
c5e8590
Compare
c5e8590 to
ffa8ca2
Compare
|
About adding a test that would have cached the change and make the module fail. I agree it would have been good to have one, but I am not sure of the pertinence of adding it afterwards. But I have updated the tests to use the RunJobController class and not an instance of it. queue/queue_job/controllers/main.py Line 108 in 1164f05 |
That module was develop before this change
The new module tests were not affected by the change when merging.