[14.0][MIG] report_label by StefanRijnhart · Pull Request #502 · OCA/reporting-engine

StefanRijnhart · 2021-04-20T13:53:36Z

No description provided.

ivantodorovich

Code review LGTM 👍
gh is complaining about pre-commit though, would you check?

StefanRijnhart · 2021-04-20T14:01:28Z

@ivantodorovich fixed now. Thanks for the nice module BTW!

ivantodorovich · 2021-04-20T14:03:01Z

@ivantodorovich fixed now. Thanks for the nice module BTW!

Thank you for migrating it ❤️

rousseldenis · 2021-12-09T14:19:17Z

+    "category": "Reporting",
+    "maintainers": ["ivantodorovich"],
+    "depends": [
+        "base",


@StefanRijnhart I have a problem launching an update --all after having installed report_label.

Adding 'base_automation' here solves the problem, but I haven't found the root problem.

Thanks, I'll have a look

There you have it: https://github.com/odoo/odoo/blob/14.0/addons/base_automation/views/base_automation_view.xml#L8-L9. Base automation extends the view from ir.actions.server but report_label's button is invalid for that model unless report_label depends on base_automation so that the button's action is also available on the base.automation model (which also inherits from the ir.actions.server model, by delegation)
I added the module dependency because I can't think of a less hacky way around it at this moment.

Daniel-CA

LGTM

OCA-git-bot · 2022-01-11T08:25:39Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

andreampiovesana

go

elvise · 2022-05-10T14:45:05Z

@StefanRijnhart can you rebase please ?

elvise · 2022-05-10T14:46:12Z

@rousseldenis merge ?

StefanRijnhart · 2022-05-10T16:02:43Z

@elvise rebase done.

francesco-ooops · 2022-05-10T16:41:31Z

@StefanRijnhart error in precommit prevents module installation in runboat, would you have some time to try to fix it?
let us know if you need any help.

…er actions

francesco-ooops · 2022-05-11T09:46:07Z

It's marked for installation in the runboat logs, but the logs stop after installing module 39 out of 48: https://runboat.odoo-community.org/api/v1/builds/b99a74bb9-617a-4279-bd2f-2aae739565d9/init-log. Do you know what could have caused that?

@sbidoul any hint on this behavior?

francesco-ooops · 2022-05-11T10:56:55Z

seems runboat can't load correctly module kpi_dashboard_bokeh in any PR in this repo after it was merged here, @etobella do you have any idea what could be the cause?

sbidoul · 2022-05-11T12:25:15Z

I see no additional information on the cluster. So it looks like the installation indeed exited with code 0 before having finished... this might be reproducible locally.

francesco-ooops

on the functional side: I followed configuration + usage instructions and tried to use demo data from the module itself, but after launching the server action a document layout page that seems out of context pops up, and label is not printed

not sure if the problem lies with demo data or code as I cannot compare behavior with v.12 as runboat has issues

StefanRijnhart · 2022-05-11T16:17:47Z

That would be the standard document layout popout that you need to go through on every new Odoo database. What happens if you go through that wizard and then try again?

francesco-ooops · 2022-05-11T16:25:18Z

That would be the standard document layout popout that you need to go through on every new Odoo database.

Which option should be selected for the module to work?

What happens if you go through that wizard and then try again?

"The server encountered an internal error and was unable to complete your request. Either the server is overloaded or there is an error in the application."

StefanRijnhart · 2022-05-11T16:40:33Z

Any option will do. It's just to determine the basic layout for other kinds of reports.

I tried printing the labels on a fresh install, and I do not encounter an error:

francesco-ooops

good for me then, maybe it's due to the runboat not building completely in the first place

who can we ask for merge?

OCA-git-bot · 2022-05-11T17:00:01Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

StefanRijnhart · 2022-05-11T17:18:20Z

Ah, you installed the module manually on runboat. In that case I can fetch the error from the logs there, and it's

Traceback (most recent call last):
  File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 237, in _dispatch
    result = request.dispatch()
  File "/opt/odoo/odoo/http.py", line 806, in dispatch
    r = self._call_function(**self.params)
  File "/opt/odoo/odoo/http.py", line 359, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/opt/odoo/odoo/service/model.py", line 94, in wrapper
    return f(dbname, *args, **kwargs)
  File "/opt/odoo/odoo/http.py", line 347, in checked_call
    result = self.endpoint(*a, **kw)
  File "/opt/odoo/odoo/http.py", line 912, in __call__
    return self.method(*args, **kw)
  File "/opt/odoo/odoo/http.py", line 531, in response_wrap
    response = f(*args, **kw)
  File "/mnt/data/odoo-addons-dir/report_xml/controllers/main.py", line 95, in report_download
    return super().report_download(data, token, context)
  File "/opt/odoo/odoo/http.py", line 531, in response_wrap
    response = f(*args, **kw)
Exception

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/opt/odoo-venv/lib/python3.6/site-packages/werkzeug/serving.py", line 306, in run_wsgi
    execute(self.server.app)
  File "/opt/odoo-venv/lib/python3.6/site-packages/werkzeug/serving.py", line 294, in execute
    application_iter = app(environ, start_response)
  File "/opt/odoo/odoo/service/server.py", line 441, in app
    return self.app(e, s)
  File "/opt/odoo/odoo/service/wsgi_server.py", line 113, in application
    return application_unproxied(environ, start_response)
  File "/opt/odoo/odoo/service/wsgi_server.py", line 88, in application_unproxied
    result = odoo.http.root(environ, start_response)
  File "/opt/odoo/odoo/http.py", line 1328, in __call__
    return self.dispatch(environ, start_response)
  File "/opt/odoo/odoo/http.py", line 1294, in __call__
    return self.app(environ, start_wrapped)
  File "/opt/odoo-venv/lib/python3.6/site-packages/werkzeug/middleware/shared_data.py", line 220, in __call__
    return self.app(environ, start_response)
  File "/opt/odoo/odoo/http.py", line 1518, in dispatch
    result = ir_http._dispatch()
  File "/opt/odoo/addons/auth_signup/models/ir_http.py", line 19, in _dispatch
    return super(Http, cls)._dispatch()
  File "/opt/odoo/addons/web_editor/models/ir_http.py", line 21, in _dispatch
    return super(IrHttp, cls)._dispatch()
  File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 241, in _dispatch
    return cls._handle_exception(e)
  File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 209, in _handle_exception
    return request._handle_exception(exception)
  File "/opt/odoo/odoo/http.py", line 744, in _handle_exception
    return super(HttpRequest, self)._handle_exception(exception)
  File "/opt/odoo/odoo/http.py", line 315, in _handle_exception
    raise exception.with_traceback(None) from new_cause
TypeError: report_download() takes 3 positional arguments but 4 were given - - -

Let me try to fix it here.

StefanRijnhart · 2022-05-11T18:05:02Z

@francesco-ooops I Just checked on runboat, after manual installation of the module and selection of the company reporting style, you can now print the demo labels from the module in this PR.

francesco-ooops · 2022-05-12T07:39:14Z

@francesco-ooops I Just checked on runboat, after manual installation of the module and selection of the company reporting style, you can now print the demo labels from the module in this PR.

confirmed, LGTM now!

francesco-ooops · 2022-05-13T08:12:17Z

@OCA/reporting-engine-maintainers can we proceed with merge?

github-actions · 2022-09-25T12:35:07Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

HviorForgeFlow · 2022-09-27T06:47:05Z

/ocabot merge nobump

OCA-git-bot · 2022-09-27T06:47:13Z

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-502-by-HviorForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot · 2022-09-27T06:58:08Z

Congratulations, your PR was merged at f8a77f8. Thanks a lot for contributing to OCA. ❤️

toan-syncoria · 2022-09-29T04:08:55Z

Do we have ver 15?

StefanRijnhart added this to the 14.0 milestone Apr 20, 2021

StefanRijnhart requested a review from ivantodorovich April 20, 2021 13:53

StefanRijnhart changed the title ~~[14.0][MIG] report label~~ [14.0][MIG] report_label Apr 20, 2021

ivantodorovich approved these changes Apr 20, 2021

View reviewed changes

StefanRijnhart force-pushed the mig/14.0/report_label branch from 04cb516 to 3d924cc Compare April 20, 2021 13:59

StefanRijnhart force-pushed the mig/14.0/report_label branch 2 times, most recently from b776e40 to 8d08f00 Compare April 20, 2021 15:28

rousseldenis reviewed Dec 9, 2021

View reviewed changes

StefanRijnhart force-pushed the mig/14.0/report_label branch 3 times, most recently from 742c7c1 to 35ae1bf Compare December 9, 2021 19:42

Daniel-CA approved these changes Jan 11, 2022

View reviewed changes

OCA-git-bot added approved ready to merge labels Jan 11, 2022

andreampiovesana approved these changes Feb 17, 2022

View reviewed changes

ivantodorovich and others added 4 commits May 10, 2022 18:00

[ADD] report_label

c6f34b6

[UPD] Update report_label.pot

92d3487

[UPD] README.rst

a16e4c7

[ADD] icon.png

7605b7c

StefanRijnhart force-pushed the mig/14.0/report_label branch from 35ae1bf to 0418334 Compare May 10, 2022 16:02

StefanRijnhart added 3 commits May 10, 2022 19:19

[IMP] report_label: black, isort, prettier

c6c0ef3

[MIG] report_label: Migration to 14.0

c55eea9

[FIX] report_label: work around base.automation's inheritance of serv…

cac81c9

…er actions

francesco-ooops suggested changes May 11, 2022

View reviewed changes

OCA-git-bot removed approved ready to merge labels May 11, 2022

francesco-ooops approved these changes May 11, 2022

View reviewed changes

OCA-git-bot added approved ready to merge labels May 11, 2022

StefanRijnhart added 2 commits May 11, 2022 19:22

[FIX] report_qweb_encrypt: the case without res_ids

7090dc3

[FIX] report_download controller method signature in two modules

db971c4

elvise mentioned this pull request Jun 11, 2022

[14.0][ADD] product_attribute_value_price_import module OCA/product-attribute#1079

Merged

github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 25, 2022

OCA-git-bot added the bot is merging ⏳ label Sep 27, 2022

OCA-git-bot merged commit 755c3bd into OCA:14.0 Sep 27, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Sep 27, 2022

Uh oh!

Conversation

StefanRijnhart commented Apr 20, 2021

Uh oh!

ivantodorovich left a comment

Choose a reason for hiding this comment

Uh oh!

StefanRijnhart commented Apr 20, 2021

Uh oh!

ivantodorovich commented Apr 20, 2021

Uh oh!

rousseldenis Dec 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

StefanRijnhart Dec 9, 2021

Choose a reason for hiding this comment

Uh oh!

StefanRijnhart Dec 9, 2021

Choose a reason for hiding this comment

Uh oh!

Daniel-CA left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Jan 11, 2022

Uh oh!

andreampiovesana left a comment

Choose a reason for hiding this comment

Uh oh!

elvise commented May 10, 2022

Uh oh!

elvise commented May 10, 2022

Uh oh!

StefanRijnhart commented May 10, 2022

Uh oh!

francesco-ooops commented May 10, 2022

Uh oh!

francesco-ooops commented May 11, 2022

Uh oh!

francesco-ooops commented May 11, 2022

Uh oh!

sbidoul commented May 11, 2022

Uh oh!

francesco-ooops left a comment

Choose a reason for hiding this comment

Uh oh!

StefanRijnhart commented May 11, 2022

Uh oh!

francesco-ooops commented May 11, 2022

Uh oh!

StefanRijnhart commented May 11, 2022

Uh oh!

francesco-ooops left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented May 11, 2022

Uh oh!

StefanRijnhart commented May 11, 2022

Uh oh!

StefanRijnhart commented May 11, 2022

Uh oh!

francesco-ooops commented May 12, 2022

Uh oh!

francesco-ooops commented May 13, 2022

Uh oh!

github-actions Bot commented Sep 25, 2022

Uh oh!

HviorForgeFlow commented Sep 27, 2022

Uh oh!

OCA-git-bot commented Sep 27, 2022

Uh oh!

OCA-git-bot commented Sep 27, 2022

Uh oh!

toan-syncoria commented Sep 29, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

rousseldenis Dec 9, 2021 •

edited

Loading