Skip to content

[14.0][MIG] report_csv: Migration to 14.0#511

Merged
OCA-git-bot merged 19 commits intoOCA:14.0from
Studio73:14.0-mig-report_csv
May 16, 2022
Merged

[14.0][MIG] report_csv: Migration to 14.0#511
OCA-git-bot merged 19 commits intoOCA:14.0from
Studio73:14.0-mig-report_csv

Conversation

@ferran-S73
Copy link
Copy Markdown

Original pull request #442

Updates and resolves conflicts

@ferran-S73 ferran-S73 force-pushed the 14.0-mig-report_csv branch from 60fb4f1 to 197ccc2 Compare June 3, 2021 10:59
Comment thread report_csv/__manifest__.py Outdated
Comment thread requirements.txt Outdated
@ferran-S73 ferran-S73 force-pushed the 14.0-mig-report_csv branch from 197ccc2 to 3e0eed1 Compare June 30, 2021 06:19
@ferran-S73 ferran-S73 force-pushed the 14.0-mig-report_csv branch from 3e0eed1 to 060c2b3 Compare July 15, 2021 10:08
@ferran-S73
Copy link
Copy Markdown
Author

@davejames could you review please?

Copy link
Copy Markdown

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge?

@adrienpeiffer
Copy link
Copy Markdown

@OCA/reporting-engine-maintainers Could we merge this ?

@etobella
Copy link
Copy Markdown
Member

etobella commented May 3, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-511-by-etobella-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 3, 2022
Signed-off-by etobella
@OCA-git-bot
Copy link
Copy Markdown
Contributor

@etobella your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-511-by-etobella-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@etobella
Copy link
Copy Markdown
Member

etobella commented May 3, 2022

Can you rebase?

@ferran-S73 ferran-S73 force-pushed the 14.0-mig-report_csv branch from 060c2b3 to b1546b8 Compare May 3, 2022 15:16
@ferran-S73
Copy link
Copy Markdown
Author

Can you rebase?

@etobella done

@etobella
Copy link
Copy Markdown
Member

etobella commented May 3, 2022

tests fail might be unrelated, but can you reexecute pre-commit?

@ferran-S73
Copy link
Copy Markdown
Author

tests fail might be unrelated, but can you reexecute pre-commit?

It's working just fine on my local env

@etobella
Copy link
Copy Markdown
Member

etobella commented May 3, 2022

Setup folder has not been added

@ferran-S73 ferran-S73 force-pushed the 14.0-mig-report_csv branch from b1546b8 to f2f016d Compare May 4, 2022 06:39
@ferran-S73
Copy link
Copy Markdown
Author

Setup folder has not been added

I've added the setup folder generated by pre-commit locally

@ferran-S73
Copy link
Copy Markdown
Author

@etobella @adrienpeiffer @andreampiovesana @newtratip @OCA/reporting-engine-maintainers anyone has idea why is the test failing to donwload openjdk?

@etobella
Copy link
Copy Markdown
Member

There was an error with the CI Image. Now it has been fixed 😄

@etobella
Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-511-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 625e254 into OCA:14.0 May 16, 2022
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 4f8d3c7. Thanks a lot for contributing to OCA. ❤️

@ferran-S73 ferran-S73 deleted the 14.0-mig-report_csv branch May 16, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.