Skip to content

[WIP] report_async#600

Closed
KKamaa wants to merge 1 commit intoOCA:14.0from
sunflowerit:14.0-mig-report_async
Closed

[WIP] report_async#600
KKamaa wants to merge 1 commit intoOCA:14.0from
sunflowerit:14.0-mig-report_async

Conversation

@KKamaa
Copy link
Copy Markdown
Contributor

@KKamaa KKamaa commented Mar 22, 2022

So this is an improvement from:

@KKamaa KKamaa force-pushed the 14.0-mig-report_async branch from 405d62a to ff65198 Compare March 22, 2022 04:02
@kittiu
Copy link
Copy Markdown
Member

kittiu commented Mar 22, 2022

@KKamaa if you have improvement now, you need to checkout a branch from https://github.com/ecosoft-odoo/reporting-engine/tree/14.0-mig-report_async and propose PR to it. Then others can help review your change.

Otherwise, to be more simple, you need to wait until the 14.0-mig-report_async is merged into 14.0 and then you checkout a branch from 14.0 and propose PR to it.

May be you help review https://github.com/ecosoft-odoo/reporting-engine/tree/14.0-mig-report_async and approve it so maintainer know it is ready. WDYT?

@KKamaa
Copy link
Copy Markdown
Contributor Author

KKamaa commented Mar 22, 2022

@KKamaa if you have improvement now, you need to checkout a branch from https://github.com/ecosoft-odoo/reporting-engine/tree/14.0-mig-report_async and propose PR to it. Then others can help review your change.

Otherwise, to be more simple, you need to wait until the 14.0-mig-report_async is merged into 14.0 and then you checkout a branch from 14.0 and propose PR to it.

May be you help review https://github.com/ecosoft-odoo/reporting-engine/tree/14.0-mig-report_async and approve it so maintainer know it is ready. WDYT?

Hey @kittiu thanks for the feedback, could also please rebase your current MR on report_async to OCA current v14.0 its kinda on an old base it leads to unrelated histories refusing to merge.

@KKamaa
Copy link
Copy Markdown
Contributor Author

KKamaa commented Mar 23, 2022

@kittiu as you suggested will close this and wait for a merge then do IMP to the merged one hopefully after the main MR has also been rebased.

@KKamaa KKamaa closed this Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants