[18.0][FIX] rma_sale_delivery: Use proper available carriers method#582
Merged
OCA-git-bot merged 1 commit intoOCA:18.0from May 6, 2026
Merged
Conversation
We can't use the RMA one, as it doesn't exist yet. Not sure though if the sales order check is enough, or there should be something more, as this is a return. TT62250
Contributor
|
Hi @victoralmau, |
| carrier_model._check_company_domain(item.company_id) | ||
| ) | ||
| item.available_reception_carrier_ids = ( | ||
| carriers.available_carriers_rma(partner, item.order_id) |
There was a problem hiding this comment.
Sorry, but I don’t understand what the error is.
This method is available at
Member
Author
There was a problem hiding this comment.
Because it expects a RMA, not a sales order...
carlos-lopez-tecnativa
approved these changes
May 4, 2026
| carrier_model._check_company_domain(item.company_id) | ||
| ) | ||
| item.available_reception_carrier_ids = ( | ||
| carriers.available_carriers_rma(partner, item.order_id) |
victoralmau
approved these changes
May 6, 2026
Member
Author
|
/ocabot merge patch |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 6feff02. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't use the RMA one, as it doesn't exist yet. Not sure though if the sales order check is enough, or there should be something more, as this is a return.
@Tecnativa TT62250