Skip to content

[18.0][FIX] rma + rma_sale: Full RMA workflow without additional permissions (Inventory or Sales)#583

Merged
OCA-git-bot merged 3 commits into
OCA:18.0from
Tecnativa:18.0-fix-rma-rma-user
May 15, 2026
Merged

[18.0][FIX] rma + rma_sale: Full RMA workflow without additional permissions (Inventory or Sales)#583
OCA-git-bot merged 3 commits into
OCA:18.0from
Tecnativa:18.0-fix-rma-rma-user

Conversation

@victoralmau
Copy link
Copy Markdown
Member

@victoralmau victoralmau commented May 12, 2026

Full RMA workflow without additional permissions (Inventory or Sales)

Please @pedrobaeza and @carlos-lopez-tecnativa can you review it?

@Tecnativa

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hi @pedrobaeza, @chienandalu,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot OCA-git-bot added mod:rma Module rma series:18.0 mod:rma_sale Module rma_sale labels May 12, 2026
@pedrobaeza pedrobaeza added this to the 18.0 milestone May 12, 2026
@victoralmau victoralmau marked this pull request as ready for review May 12, 2026 09:16
@pedrobaeza
Copy link
Copy Markdown
Member

To which point is the RMA module functional without stock permissions? Should we go this way to restrict visibility, or should we grant equivalent stock permissions to RMA users?

@victoralmau
Copy link
Copy Markdown
Member Author

Although it’s not common (or at least that’s what I think) to use the RMA module without inventory permissions, it could happen; I don’t think inheriting permissions is appropriate, nor is adding ACLs for everything related to inventory, which is why these changes have been done.

There are some changes related to sales permissions that I could probably add in a separate commit or a separate PR if you prefer.

Comment thread rma/models/rma.py
It is important that all delivery moves be either canceled or done, because
a delivery move might be created, canceled (for example, because the wrong
product was used), recreated, and then done.
@victoralmau victoralmau force-pushed the 18.0-fix-rma-rma-user branch from b9c3826 to 9c5f3fb Compare May 15, 2026 07:36
Copy link
Copy Markdown

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza
Copy link
Copy Markdown
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-583-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 694cec5 into OCA:18.0 May 15, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 76a7366. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 18.0-fix-rma-rma-user branch May 15, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants