[18.0][IMP] rma_lot: Add domain_lot_id field to lot_id field#586
Merged
Conversation
pedrobaeza
approved these changes
May 19, 2026
pilarvargas-tecnativa
approved these changes
May 19, 2026
Similar to sale_order_lot_selection TT61756
victoralmau
force-pushed
the
18.0-imp-rma_lot-domain_lot_id
branch
from
6445fac to
a6d584e
Compare
Member
Author
|
This is ready to merge, right? |
Member
|
Not really, as the rules state that it should be 3 approvals or 2 and 5 working days, and this one not being our module, it's not fair to not let others to give their opinion being a new behavior. If we have the @sbejaoui's blessing, we can continue. |
Contributor
|
This PR has the |
Member
Author
Member
|
/ocabot merge minor |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at d6e0db3. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add domain_lot_id field to lot_id field
Similar to
sale_order_lot_selectionPlease @pedrobaeza and @pilarvargas-tecnativa can you review it?
@Tecnativa TT62586