Skip to content

[18.0][IMP] rma_sale: Set fiscal_position_id on the refund invoice#590

Merged
OCA-git-bot merged 2 commits into
OCA:18.0from
Tecnativa:18.0-fix-rma-TT62787
May 29, 2026
Merged

[18.0][IMP] rma_sale: Set fiscal_position_id on the refund invoice#590
OCA-git-bot merged 2 commits into
OCA:18.0from
Tecnativa:18.0-fix-rma-TT62787

Conversation

@victoralmau
Copy link
Copy Markdown
Member

@victoralmau victoralmau commented May 28, 2026

Changes done:

  • rma: Add partner_shipping_id to refund invoice
  • rma_sale: Set fiscal_position_id on the refund invoice

Please @carlosdauden, @carlos-lopez-tecnativa and @pedrobaeza can you review it?

@Tecnativa TT62787 TT62768

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hi @chienandalu, @pedrobaeza,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot OCA-git-bot added mod:rma Module rma series:18.0 mod:rma_sale Module rma_sale labels May 28, 2026
Comment thread rma_sale/models/rma.py
@pedrobaeza pedrobaeza added this to the 18.0 milestone May 29, 2026
Copy link
Copy Markdown

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza
Copy link
Copy Markdown
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-590-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 403c0ae into OCA:18.0 May 29, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 048bc81. Thanks a lot for contributing to OCA. ❤️

@carlos-lopez-tecnativa carlos-lopez-tecnativa deleted the 18.0-fix-rma-TT62787 branch May 29, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants