[18.0][MIG] auth_user_case_insensitive: Migration to 18.0 #712
Conversation
…f `_login` * Update code and tests to override `_login` method
Currently translated at 100.0% (2 of 2 strings) Translation: server-auth-12.0/server-auth-12.0-auth_user_case_insensitive Translate-URL: https://translation.odoo-community.org/projects/server-auth-12-0/server-auth-12-0-auth_user_case_insensitive/pt_BR/
Currently translated at 100.0% (4 of 4 strings) Translation: server-auth-16.0/server-auth-16.0-auth_user_case_insensitive Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_user_case_insensitive/es/
Currently translated at 100.0% (4 of 4 strings) Translation: server-auth-16.0/server-auth-16.0-auth_user_case_insensitive Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_user_case_insensitive/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-17.0/server-auth-17.0-auth_user_case_insensitive Translate-URL: https://translation.odoo-community.org/projects/server-auth-17-0/server-auth-17-0-auth_user_case_insensitive/
|
@dreispt I have migrated the module and tested it locally and it works fine. I'm facing a problem with the test cases. Normally the super()._login method takes login and password but in Odoo 18 it takes a credentials object. I tried modifying the test case to match the new behavior but I can't figure it out. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
amh-mw
left a comment
amh-mw
left a comment
There was a problem hiding this comment.
- All the [MIG] commits should be squashed together with the change to the contributors file
- The [IMP] pre-commit commit is done before any migration changes; see https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0#technical-method-to-migrate-a-module-from-170-to-180-branch
github-actions
bot
removed
the
stale
JessBrandl
left a comment
JessBrandl
left a comment
There was a problem hiding this comment.
Agreed with the other review + small improvement in comment
| raise ValidationError( | ||
| _("Conflicting user logins exist for `%s`", login) | ||
| ) | ||
|
|
There was a problem hiding this comment.
Possible small performance improvement according to the migration docs
You can replace the call to translate a string ( _ ) with self.env._ for getting some performance improvement in some cases. See odoo/odoo#174844.
|
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
13 participants
auth_user_case_insensitive Migration to 18.0