Skip to content

[18.0][MIG] impersonate_login#714

Closed
astirpe wants to merge 11 commits intoOCA:18.0from
astirpe:18_mig_impersonate_login
Closed

[18.0][MIG] impersonate_login#714
astirpe wants to merge 11 commits intoOCA:18.0from
astirpe:18_mig_impersonate_login

Conversation

@astirpe
Copy link
Copy Markdown
Member

@astirpe astirpe commented Oct 17, 2024

Standard migration.
Includes #686

@astirpe astirpe marked this pull request as ready for review October 17, 2024 07:02
Copy link
Copy Markdown
Member

@bealdav bealdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested feature, works as expected

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sebastienbeau
Copy link
Copy Markdown
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-714-by-sebastienbeau-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 19, 2024
Signed-off-by sebastienbeau
@OCA-git-bot
Copy link
Copy Markdown
Contributor

@sebastienbeau your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-714-by-sebastienbeau-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@square-ava
Copy link
Copy Markdown

@sebastienbeau Can you check the issue when merging here, pre-commit test seems to fail, but it seems successful on the pr.

@sebastienbeau
Copy link
Copy Markdown
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-714-by-sebastienbeau-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 2, 2025
Signed-off-by sebastienbeau
@OCA-git-bot
Copy link
Copy Markdown
Contributor

@sebastienbeau your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-714-by-sebastienbeau-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@sebastienbeau
Copy link
Copy Markdown
Member

@astirpe can you do a rebase here ? I think the pre-commit in the main branch have been updated

@astirpe
Copy link
Copy Markdown
Member Author

astirpe commented Apr 5, 2025

@sebastienbeau
I was not able to rebase this one, so I opened a new PR. Sorry.

Closing this PR, replaced by #784

@astirpe astirpe closed this Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants