[17.0][ADD] apikey_scope_editable#807
Conversation
Tisho99
force-pushed
the
17.0-add-apikey_scope_editable
branch
from
c0ca572 to
fb28d7a
Compare
| class APIKeyDescription(models.TransientModel): | ||
| _inherit = "res.users.apikeys.description" | ||
|
|
||
| scope = fields.Char() |
There was a problem hiding this comment.
Shouldn't this be a selection to avoid errors, or at least to have a hint about what to fill?
There was a problem hiding this comment.
Hi Pedro, thanks for the review.
I'd rather give a hint: the original scope field to which this propagates is a char and can have any value. I'll try to improve the module's documentation to make it easier to understand.
There was a problem hiding this comment.
Hi @pedrobaeza
Upon closer inspection, I think what you said about changing it to a selection seems fine. I've made the change to offer a selection of values, added the option to enter free text, and modified the description a bit.
Does it seem better to you?
Tisho99
force-pushed
the
17.0-add-apikey_scope_editable
branch
from
fb28d7a to
92b0b7e
Compare
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 4a54e5d. Thanks a lot for contributing to OCA. ❤️ |
4 participants
This module allows you to set an API Key scope on its creation, a field used by odoo to filter the used api keys
T-8323