[18.0][IMP] impersonate_login: Optimize database performance for partner deletion #840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtanuiha
changed the title
Contributor
|
Hi @Kev-Roche, |
Contributor
|
The name of the changed module is missing from the title and the commit message. |
xtanuiha
changed the title
xtanuiha
changed the title
Contributor
Author
Thank you for the reminder, the PR and commit message titles have been updated |
hildickethan
approved these changes
Nov 5, 2025
StefanRijnhart
approved these changes
Dec 28, 2025
Member
StefanRijnhart
left a comment
StefanRijnhart
left a comment
There was a problem hiding this comment.
Thanks! Would you be able to port to 19?
/ocabot merge minor
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at a37492d. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our production environment, the mail_message table contains approximately 8.52 million rows, and the res_partner table has about 48,000 rows.
Deleting a single partner took roughly 70 seconds. After adding the database index, the operation was optimized to complete in approximately 3 seconds.