[18.0][FIX] base_user_role_company: Roles are filtered so none which exceed date_to are used

[TomVermeerenDynapps]

Fixed a bug where disabled roles (because past date_to) were used.

[StefanRijnhart]

Maybe use this convenience method: https://github.com/OCA/server-backend/blob/14.0/base_user_role/models/user.py#L54-L55
Can you add a small test?

[TomVermeerenDynapps]

@StefanRijnhart _get_enabled_roles is the method I am overwriting, so instead of calling it (recursion error) again I will use res, this has the same functionality. I also added test scenarios.

[StefanRijnhart]

Great thanks! Only some minor comments now.

[StefanRijnhart]

Thanks for the update! Please squash the commits.

[TomVermeerenDynapps]

Comments resolved & commits squashed! Thank you for review!

[StefanRijnhart]

Apologies, one thing I missed: the module name needs to be featured in the commit message, so [FIX] base_user_role_company: ... (like the PR title actually).

[TomVermeerenDynapps]

Should be resolved now:) thank you!

[StefanRijnhart]

Thanks for the quick responses!

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[dreispt]

/ocabot merge patch

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-347-by-dreispt-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 4940e8c. Thanks a lot for contributing to OCA. ❤️