[18.0][IMP] base_user_role: New wizard to add multiple users #381
Conversation
legalsylvain
left a comment
legalsylvain
left a comment
There was a problem hiding this comment.
code review / no test.
thanks !
|
Could you review this, please? |
|
Could you review this, please? I think you have more context, it's related to https://gitlab.com/ircanada/ircodoo/-/merge_requests/4150#note_2790173889 |
rolandojduartem
left a comment
rolandojduartem
left a comment
There was a problem hiding this comment.
@luisg123v is bumping version expected here? is the target of branch fine?
Also, @jqbeltran2, please add test for the new wizard.
base_user_role/views/role.xml
Outdated
| License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl). | ||
| --> | ||
| <odoo> | ||
| <record id="action_add_multiple_users_wizard" model="ir.actions.act_window"> |
There was a problem hiding this comment.
move this action to the respective file
|
jqbeltran2
force-pushed
the
18.0-imp-base_user_role-wizard-jqbeltran2
branch
3 times, most recently
from
dbab4f9 to
3fd676c
Compare
| name="user_ids" | ||
| widget="many2many_tags" | ||
| options="{'no_create': True, 'no_create_edit': True}" | ||
| domain="[('share','=',False), ('active','=',True)]" |
This commit adds a new feature to the module: New button to open wizard so it's possible to select multiple users at once, keeping the ability to choose the dates.
jqbeltran2
force-pushed
the
18.0-imp-base_user_role-wizard-jqbeltran2
branch
from
3fd676c to
344814b
Compare
|
LGTM 👍 @luisg123v @moylop260 |
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 2289402. Thanks a lot for contributing to OCA. ❤️ |
7 participants
Description
This commit adds a new feature to the module: New button to open wizard so it's possible to select multiple
users at once, keeping the ability to choose the dates.