[18.0][MIG] base_external_dbsource_mssql: Migration to version 18.0 #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Heavily refactor code for reusability * Split all sources into independent modules * Add more test coverage * Add CRUD methods * Add iterator execute return to roadmap [UPD] Update base_external_dbsource_mssql.pot
[UPD] README.rst [UPD] Update base_external_dbsource_mssql.pot [UPD] README.rst
[UPD] Update base_external_dbsource_mssql.pot
[UPD] Update base_external_dbsource_mssql.pot
…heel for pymssql" (OCA#196) The new `pymssql==2.2.6` version released this weekend - <img width="414" alt="Screenshot 2022-11-15 at 20 11 53" src="https://user-images.githubusercontent.com/6644187/202066666-a1551d22-d50a-4c14-ae0a-dd35dc147a40.png"> requires extra setup to be installed So, it is raising new errors where it is not setup You can reproduce it running the following command: docker run -it --rm python:3.6 pip3 install -q pymssql==2.2.6 `ERROR: Could not build wheels for pymssql...` ERROR: Command errored out with exit status 1: command: /usr/local/bin/python /usr/local/lib/python3.6/site-packages/pip/_vendor/pep517/in_process/_in_process.py build_wheel /tmp/tmpmp6b33ly cwd: /tmp/pip-install-p4ocn1ip/pymssql_01748f191a744758bda6f7d536f6ec35 Complete output (25 lines): setup.py: platform.system() => Linux setup.py: platform.architecture() => ('64bit', 'ELF') setup.py: platform.libc_ver() => ('glibc', '2.2.5') setup.py: include_dirs => [] setup.py: library_dirs => [] running bdist_wheel running build running build_py creating build creating build/lib.linux-x86_64-3.6 creating build/lib.linux-x86_64-3.6/pymssql copying src/pymssql/__init__.py -> build/lib.linux-x86_64-3.6/pymssql running build_ext cythoning src/pymssql/_mssql.pyx to src/pymssql/_mssql.c cythoning src/pymssql/_pymssql.pyx to src/pymssql/_pymssql.c building 'pymssql._mssql' extension creating build/temp.linux-x86_64-3.6 creating build/temp.linux-x86_64-3.6/src creating build/temp.linux-x86_64-3.6/src/pymssql gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -I/usr/local/include/python3.6m -c src/pymssql/_mssql.c -o build/temp.linux-x86_64-3.6/src/pymssql/_mssql.o -DMSDBLIB src/pymssql/_mssql.c:747:10: fatal error: sqlfront.h: No such file or directory 747 | #include "sqlfront.h" | ^~~~~~~~~~~~ compilation terminated. error: command 'gcc' failed with exit status 1 ---------------------------------------- ERROR: Failed building wheel for pymssql ERROR: Could not build wheels for pymssql which use PEP 517 and cannot be installed directly WARNING: You are using pip version 21.2.4; however, version 21.3.1 is available. You should consider upgrading via the '/usr/local/bin/python -m pip install --upgrade pip' command. FAIL However, using docker run -it --rm python:3.6 pip3 install -q pymssql==2.2.5 It is installing well! So, I have created this PR in order to fix all the error in the CI using this project and installing this package
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-backend-16.0/server-backend-16.0-base_external_dbsource_mssql Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_external_dbsource_mssql/
Currently translated at 100.0% (4 of 4 strings) Translation: server-backend-16.0/server-backend-16.0-base_external_dbsource_mssql Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_external_dbsource_mssql/es/
Currently translated at 100.0% (4 of 4 strings) Translation: server-backend-16.0/server-backend-16.0-base_external_dbsource_mssql Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_external_dbsource_mssql/it/
Currently translated at 100.0% (4 of 4 strings) Translation: server-backend-16.0/server-backend-16.0-base_external_dbsource_mssql Translate-URL: https://translation.odoo-community.org/projects/server-backend-16-0/server-backend-16-0-base_external_dbsource_mssql/pt_BR/
Member
|
/ocabot migration base_external_dbsource_mssql |
pedrobaeza
approved these changes
Nov 25, 2025
|
@christian-ramos-tecnativa Please pick this commits too. ursais#2 |
Member
|
@Nikul-OSI ODBC thing shouldn't be included in this base module, as it provokes hard library dependencies. If you want that, you should put a module on top of this one (or an alternative module called |
JordiMForgeFlow
approved these changes
Nov 27, 2025
Sure I will |
Member
|
/ocabot merge nobump |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at e7e6a2a. Thanks a lot for contributing to OCA. ❤️ |
base_external_dbsource_mssql_by_odbc = #393 @pedrobaeza @christian-ramos-tecnativa Ready to review |
Contributor
|
This PR causes trouble on odoo.sh because of the pymssql<=2.2.5 dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tecnativa TT57473
Supersedes #388
As the migration adds new dependencies and is kinda stuck
@pedrobaeza