[15.0] auth_saml_environment: removes readonly attributes to allow provider creation#177
[15.0] auth_saml_environment: removes readonly attributes to allow provider creation#177StephaneMangin wants to merge 1 commit intoOCA:15.0from
Conversation
| _name = "auth.saml.provider" | ||
| _inherit = ["auth.saml.provider", "server.env.mixin"] | ||
|
|
||
| # Mandatory to be able to create objects |
There was a problem hiding this comment.
| # Mandatory to be able to create objects | |
| # Non-mandatory to be able to create objects |
|
You don't want to state the odoo version in the commit message but rather the type of change. The odoo version is to be mentionned in the title of the PR. Can you replace the content of the commit message by: |
|
Backported here #179 |
|
idp_metadata is required for a provider to work. In a similar way, the server hostname of an outgoing server is mandatory. mail_environment does not change smtp_host to be optional, so I do not see why this module would do so for idp_metadata. For sp_pem_public and and sp_pem_private, I would recommend fixing issue OCA/server-auth/issues/315 in auth_saml that made me change them to mandatory rather than adding another level of work around. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Some readonly fields prevent the creation of a provider. Removing them as they will be managed by the env.
Following change in OCA/server-auth#342
(edit @yvaucher adding link to the source of the issue)