[IMP] server_environment: allow env variable conf#189
Merged
Conversation
gurneyalex
approved these changes
Jun 25, 2024
denaux
force-pushed
the
17.0-mig-server_environment
branch
from
f77ac73 to
38090e1
Compare
Author
|
@simahawk Thanks for the heads-up. This should be fixed now. |
nilshamerlinck
approved these changes
Jul 11, 2024
simahawk
approved these changes
Jul 11, 2024
Contributor
|
/ocabot merge minor Thanks! Would you mind opening a PR for 14 and 15? |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
This PR has the |
Contributor
|
Congratulations, your PR was merged at 759299b. Thanks a lot for contributing to OCA. ❤️ |
ivantodorovich
added a commit
to camptocamp/docker-odoo-project
that referenced
this pull request
Jun 30, 2026
Originally, this was the only way to configure the running environment for the server_environment module. 3 years ago, a PR improved the module in version 14.0, to read the running environment from the environment variable `RUNNING_ENV` instead of the config file, if set. Original PR in 14.0: - OCA/server-env#146 Later, this PR was forward ported to 16.0 and 17.0 (sadly no 15.0): - 15.0: NOT PORTED - 16.0: OCA/server-env#223 - 17.0: OCA/server-env#189 Finally, it was fully integrated into the migrations to 18.0 and 19.0. So it's safe to assume that in 18.0 and 19.0, no matter the module version used, the running environment will be read from the RUNNING_ENV variable. --- In 19.0, Odoo started complaining about unknown config file options, so this supresses the following warning: ``` WARNING ? odoo.tools.config: unknown option 'running_env' in the config file at /etc/odoo.cfg, option stored as-is, without parsing ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to propose a forward port of one specific commit from v14. This opens up compatibility with Odoo.sh.