Skip to content

[FIX] sql_request_abstract: regression#2317

Merged
OCA-git-bot merged 1 commit intoOCA:14.0from
sunflowerit:14.0-sql_quest_abstract-regression
Apr 8, 2022
Merged

[FIX] sql_request_abstract: regression#2317
OCA-git-bot merged 1 commit intoOCA:14.0from
sunflowerit:14.0-sql_quest_abstract-regression

Conversation

@thomaspaulb
Copy link
Copy Markdown
Contributor

Fixes regression introduced by this commit leading to issues with tests such as:

    rollback_name = self._create_savepoint()
TypeError: _create_savepoint() missing 1 required positional argument: 'cr'

@florian-dacosta

Comment thread sql_request_abstract/models/sql_request_mixin.py Outdated
@florian-dacosta
Copy link
Copy Markdown
Contributor

@legalsylvain

@thomaspaulb thomaspaulb force-pushed the 14.0-sql_quest_abstract-regression branch from ffbea23 to af9cec9 Compare March 25, 2022 19:37
@thomaspaulb
Copy link
Copy Markdown
Contributor Author

Squashed. @StefanRijnhart are you someone who can merge?

@thomaspaulb
Copy link
Copy Markdown
Contributor Author

@hbrunn

@StefanRijnhart
Copy link
Copy Markdown
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-2317-by-StefanRijnhart-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 765fc0e into OCA:14.0 Apr 8, 2022
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 4ef3509. Thanks a lot for contributing to OCA. ❤️

@thomaspaulb thomaspaulb deleted the 14.0-sql_quest_abstract-regression branch April 8, 2022 20:38
@thomaspaulb
Copy link
Copy Markdown
Contributor Author

Thanks @StefanRijnhart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants