[16.0][IMP] upgrade_analysis: avoid private methods

[MiquelRForgeFlow]

Avoids issue with accessing private methods (due to odoo/odoo@a1adf83).

I am not sure if I did correctly the monkey patch, it's not tested.

[OCA-git-bot]

Hi @legalsylvain, @StefanRijnhart,
some modules you are maintaining are being modified, check this out!

[StefanRijnhart]

For my (limited) understanding, do you have a concrete example where a migration triggers the exception?

[MiquelRForgeFlow]

This month, when I did a new analysis for v17, it broke when trying to access the mapped method, which is decorated with @api.private. This method is called in https://github.com/OCA/server-tools/blob/16.0/upgrade_analysis/models/upgrade_analysis.py#L554.

[StefanRijnhart]

Thanks for clarifying. Can't believe they private'd mapped! It is literally mentioned as a cool trick in OdooRPC's documentation. Can you add this example to the documentation string of the monkey patch?

[StefanRijnhart]

This is not how the odoo patch mechanism of this module works. The mechanism works with a derived class: https://github.com/OCA/server-tools/blob/16.0/upgrade_analysis/odoo_patch/odoo/modules/registry.py.

But a patch using the mechanism would not work, because it is only active on the calling side, and the mechanism is not applied when doing remote communication.

Maybe we should ask Odoo to reconsider privating mapped? Is it just this one method or are other calls affected as well?

[StefanRijnhart]

FYI @sebalix OdooRPC is impacted by this new way of 'privatization' in Odoo.

[legalsylvain]

Hi @MiquelRForgeFlow. thanks for your investigation.

At a first sight, I'm not in favor to add core patch, if it's not necessary. Here, If I'm right, #3218 can solve the problem you mention.
What do you think ?

thanks !

[MiquelRForgeFlow]

Ok, let's replace this by #3218.