[18.0][IMP] database_cleanup: add table purge blacklist with known non-model table #3240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanRijnhart
changed the title
StefanRijnhart
changed the title
StefanRijnhart
force-pushed
the
18.0-imp-database_cleanup-blacklist_table_endpoint_route
branch
from
a59d521 to
2a77866
Compare
hbrunn
approved these changes
Mar 26, 2025
Member
Author
|
@simahawk as the maintainer of the affected module, this may be of interest to you. Without this PR, database_cleanup will happily propose to remove table |
Member
Author
|
@pedrobaeza @legalsylvain apologies for the mention, but without this change database_cleanup will let Odoo crash immediately if all suggested tables are dropped on databases with |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 6f6db79. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the culprit: https://github.com/OCA/web-api/blob/18.0/endpoint_route_handler/registry.py#L73