[18.0][IMP] base_exception: Allow filtering records before exception evalua…

[grindtildeath]

…tion

[OCA-git-bot]

Hi @hparfr, @sebastienbeau,
some modules you are maintaining are being modified, check this out!

[simahawk]

LGTM. Minor remark only.

[simahawk]

Suggested change

	help="If present, this condition must be satisfied to trigger the exception.",
	help="If present, this condition must be satisfied to trigger the exception, no matter the Exception type.",

[hparfr]

Hi,

Can you explain why / how to use in the usage.md.

I guess it's a kind of a pre-filter to skip the test of exception on some records. Is it ?

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[grindtildeath]

@hparfr Yes it's a pre filter to segregate records from a same model where an exception could apply or not.

However, there are no configuration instructions or USAGE in the readme of this module, so I'm not sure it would make much sense to describe this filter when there isn't any other instructions on how to configure exceptions... 🤷

[hparfr]

However, there are no configuration instructions or USAGE in the readme of this module, so I'm not sure it would make much sense to describe this filter when there isn't any other instructions on how to configure exceptions... 🤷

It's never too late add some doc. At least a small word the source code can be good enough.

The reason you want to add this filtering feature was not obvious to me because I don't see the benefit in my case (mainly detect by domain exceptions): the filtering is already done with the domain.

If I understand correctly, the prefilter has positive impact on perfs for detecting exception by python code and negative for detecting exceptions by domain.